[Bugs] [Bug 1223318] New: brick-op failure for glusterd command should log error message in cmd_history.log

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1223318

            Bug ID: 1223318
           Summary: brick-op failure for glusterd command should log error
                    message in cmd_history.log
           Product: GlusterFS
           Version: 3.7.0
         Component: glusterd
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: amukherj at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
        Depends On: 1219732



+++ This bug was initially created as a clone of Bug #1219732 +++

Description of problem:

In glusterd brick-op if underlying transport connection is broken between
glusterd and brick, then the command fails with a blank error message

Version-Release number of selected component (if applicable):
Mainline

How reproducible:
Always

Steps to Reproduce:
1.Create a volume & start it
2. Take the glusterd process in gdb and put a break point in
gd_syncop_submit_request () and continue
3. Stop the volume
3. the breakpoint will be hit, and set to ret to -1 after rpc_clnt_submit () is
executed

Actual results:
In cmd_history.log the command will be logged as failed with no error message

Expected results:
error message should be logged.

Additional info:

--- Additional comment from Anand Avati on 2015-05-08 00:30:38 EDT ---

REVIEW: http://review.gluster.org/10659 (glusterd: populate errstr if
gd_syncop_submit_request fails) posted (#1) for review on master by Atin
Mukherjee (amukherj at redhat.com)

--- Additional comment from Anand Avati on 2015-05-08 02:40:45 EDT ---

REVIEW: http://review.gluster.org/10659 (glusterd: populate errstr if
gd_syncop_submit_request fails) posted (#2) for review on master by Atin
Mukherjee (amukherj at redhat.com)

--- Additional comment from Anand Avati on 2015-05-20 05:30:34 EDT ---

COMMIT: http://review.gluster.org/10659 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit 988db25572b94220a7cc69bcc3040c2a77b8e9a5
Author: Atin Mukherjee <amukherj at redhat.com>
Date:   Fri May 8 09:53:50 2015 +0530

    glusterd: populate errstr if gd_syncop_submit_request fails

    Change-Id: Ie4a3edef5d553fc07de53b46f9485c46a4305245
    BUG: 1219732
    Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-on: http://review.gluster.org/10659
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Tested-by: NetBSD Build System
    Reviewed-by: Krishnan Parthasarathi <kparthas at redhat.com>
    Tested-by: Krishnan Parthasarathi <kparthas at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1219732
[Bug 1219732] brick-op failure for glusterd command should log error
message in cmd_history.log
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.