[Bugs] [Bug 1222198] New: Fix nfs/mount3.c build warnings reported in Koji

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1222198

            Bug ID: 1222198
           Summary: Fix nfs/mount3.c build warnings reported in Koji
           Product: GlusterFS
           Version: 3.7.0
         Component: nfs
          Assignee: ndevos at redhat.com
          Reporter: ndevos at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
        Depends On: 1221095



+++ This bug was initially created as a clone of Bug #1221095 +++

Description of problem:

This was observed in koji. Reported by Kaleb Keithley.

mount3.c: In function '__mnt3_build_mountid_from_path':
mount3.c:705:24: warning: 'sizeof' on array function parameter 'mountid' will
return size of 'unsigned char *' [-Wsizeof-array-argument]
         length = sizeof(mountid);
                        ^
mount3.c:699:58: note: declared here
 __mnt3_build_mountid_from_path (const char *path, uuid_t mountid)
                                                          ^
mount3.c: In function '__mnt3_get_mount_id':
mount3.c:732:24: warning: 'sizeof' on array function parameter 'mountid' will
return size of 'unsigned char *' [-Wsizeof-array-argument]
         length = sizeof(mountid);
                        ^
mount3.c:726:46: note: declared here
 __mnt3_get_mount_id (xlator_t *mntxl, uuid_t mountid)

Version-Release number of selected component (if applicable): mainline

--- Additional comment from Anand Avati on 2015-05-13 11:43:35 CEST ---

REVIEW: http://review.gluster.org/10765 (nfs: Use uuid_clear() instead of
memset) posted (#1) for review on master by Vijay Bellur (vbellur at redhat.com)

--- Additional comment from Anand Avati on 2015-05-13 13:53:22 CEST ---

REVIEW: http://review.gluster.org/10765 (nfs: Use uuid_clear() instead of
memset) posted (#2) for review on master by Vijay Bellur (vbellur at redhat.com)

--- Additional comment from Anand Avati on 2015-05-16 10:23:33 CEST ---

COMMIT: http://review.gluster.org/10765 committed in master by Niels de Vos
(ndevos at redhat.com) 
------
commit df12f00851a234b0e892af4b958e606a1fa660ed
Author: Vijay Bellur <vbellur at redhat.com>
Date:   Wed May 13 11:41:31 2015 +0200

    nfs: Use uuid_clear() instead of memset

    Fixes the following incorrect usage:

    mount3.c: In function '__mnt3_build_mountid_from_path':
    mount3.c:705:24: warning: 'sizeof' on array function parameter 'mountid'
will
    return size of 'unsigned char *' [-Wsizeof-array-argument]
             length = sizeof(mountid);
                            ^
    mount3.c:699:58: note: declared here
     __mnt3_build_mountid_from_path (const char *path, uuid_t mountid)
                                                              ^
    mount3.c: In function '__mnt3_get_mount_id':
    mount3.c:732:24: warning: 'sizeof' on array function parameter 'mountid'
will
    return size of 'unsigned char *' [-Wsizeof-array-argument]
             length = sizeof(mountid);
                            ^
    mount3.c:726:46: note: declared here
     __mnt3_get_mount_id (xlator_t *mntxl, uuid_t mountid)

    Change-Id: I08f46c5994578fc99a7b61681e808d1115e41d71
    BUG: 1221095
    Signed-off-by: Vijay Bellur <vbellur at redhat.com>
    Reviewed-on: http://review.gluster.org/10765
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1221095
[Bug 1221095] Fix nfs/mount3.c build warnings reported in Koji
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aC4JrlgHUQ&a=cc_unsubscribe