[Bugs] [Bug 1221470] New: dHT rebalance: Dict_copy log messages when running rebalance on a dist-rep volume
bugzilla at redhat.com
bugzilla at redhat.com
Thu May 14 06:31:04 UTC 2015
https://bugzilla.redhat.com/show_bug.cgi?id=1221470
Bug ID: 1221470
Summary: dHT rebalance: Dict_copy log messages when running
rebalance on a dist-rep volume
Product: GlusterFS
Version: 3.7.0
Component: distribute
Assignee: bugs at gluster.org
Reporter: atalur at redhat.com
CC: atalur at redhat.com, bugs at gluster.org,
gluster-bugs at redhat.com, nbalacha at redhat.com,
spalai at redhat.com
Depends On: 1220332
+++ This bug was initially created as a clone of Bug #1220332 +++
Description of problem:
Lots of messages like the following when running rebalance on a
distribute-replicate volume:
[2015-05-11 10:52:54.690469] W [dict.c:1356:dict_copy] (-->
/usr/local/lib/libglusterfs.so.0(_gf_log_callingfn+0x1b6)[0x7fe588263236] (-->
/usr/local/lib/libglusterfs.so.0(dict_copy+0x85)[0x7fe58825e3b5] (-->
/usr/local/lib/glusterfs/3.8dev/xlator/cluster/replicate.so(afr_lookup_xattr_req_prepare+0x7e)[0x7fe57cfc27c0]
(-->
/usr/local/lib/glusterfs/3.8dev/xlator/cluster/replicate.so(afr_lookup_do+0x112)[0x7fe57cfc6752]
(-->
/usr/local/lib/glusterfs/3.8dev/xlator/cluster/replicate.so(afr_lookup+0x2bf)[0x7fe57cfc6f93]
))))) 0-dict: dict is NULL
Version-Release number of selected component (if applicable):
How reproducible:
Everytime
Steps to Reproduce:
1.Create a dist-rep volume and create some files on it
2.Rename the files to trigger file migrations
3. Start rebalance on the volume
Actual results:
Lots of the following type of messages in the rebalance log:
[2015-05-11 10:52:54.690469] W [dict.c:1356:dict_copy] (-->
/usr/local/lib/libglusterfs.so.0(_gf_log_callingfn+0x1b6)[0x7fe588263236] (-->
/usr/local/lib/libglusterfs.so.0(dict_copy+0x85)[0x7fe58825e3b5] (-->
/usr/local/lib/glusterfs/3.8dev/xlator/cluster/replicate.so(afr_lookup_xattr_req_prepare+0x7e)[0x7fe57cfc27c0]
(-->
/usr/local/lib/glusterfs/3.8dev/xlator/cluster/replicate.so(afr_lookup_do+0x112)[0x7fe57cfc6752]
(-->
/usr/local/lib/glusterfs/3.8dev/xlator/cluster/replicate.so(afr_lookup+0x2bf)[0x7fe57cfc6f93]
))))) 0-dict: dict is NULL
Expected results:
Additional info:
No such messages.
--- Additional comment from Anand Avati on 2015-05-12 03:27:53 EDT ---
REVIEW: http://review.gluster.org/10755 (cluster/afr : Do not copy dict when it
is NULL) posted (#1) for review on master by Anuradha Talur (atalur at redhat.com)
--- Additional comment from Susant Kumar Palai on 2015-05-12 09:09:35 EDT ---
RCA: __dht_rebalance_create_dst_file does syncop_lookup and does not pass
xattr_req.
<ret = syncop_lookup (to, loc, &new_stbuf, NULL, NULL, NULL);>
And afr tries to does a dict_copy from this dictionary which is NULL. Hence,
the logs. (fixed by http://review.gluster.org/10755)
--- Additional comment from Anand Avati on 2015-05-13 07:54:46 EDT ---
COMMIT: http://review.gluster.org/10755 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com)
------
commit 2b92a5c5efc29b05de88631bc5423ae3eec43812
Author: Anuradha <atalur at redhat.com>
Date: Tue May 12 12:53:30 2015 +0530
cluster/afr : Do not copy dict when it is NULL
In afr_lookup_xattr_req_prepare(), dict_copy was
done even though source dict was NULL.
Change-Id: I85a5d2823ba021e7f78c1ce13402a0f16b08cb51
BUG: 1220332
Signed-off-by: Anuradha <atalur at redhat.com>
Reviewed-on: http://review.gluster.org/10755
Reviewed-by: Ravishankar N <ravishankar at redhat.com>
Reviewed-by: Prashanth Pai <ppai at redhat.com>
Reviewed-by: Krutika Dhananjay <kdhananj at redhat.com>
Tested-by: Gluster Build System <jenkins at build.gluster.com>
Reviewed-by: Susant Palai <spalai at redhat.com>
Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1220332
[Bug 1220332] dHT rebalance: Dict_copy log messages when running rebalance
on a dist-rep volume
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
More information about the Bugs
mailing list