[Bugs] [Bug 1221128] New: `gluster volume heal <vol-name> split-brain' tries to heal even with insufficient arguments

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1221128

            Bug ID: 1221128
           Summary: `gluster volume heal <vol-name> split-brain' tries to
                    heal even with insufficient arguments
           Product: GlusterFS
           Version: mainline
         Component: replicate
          Keywords: Triaged
          Severity: medium
          Assignee: bugs at gluster.org
          Reporter: atalur at redhat.com
                CC: amukherj at redhat.com, atalur at redhat.com,
                    bugs at gluster.org, gluster-bugs at redhat.com,
                    ssampat at redhat.com
        Depends On: 1218570
            Blocks: 1186580 (qe_tracker_everglades)



+++ This bug was initially created as a clone of Bug #1218570 +++

Description of problem:
------------------------

See the following command for resolution of split-brains -

# gluster v heal <vol-name> split-brain
Usage: /usr/sbin/glfsheal <VOLNAME> [bigger-file <FILE> | source-brick
<HOSTNAME:BRICKNAME> [<FILE>] | split-brain-info]
Volume heal failed.

Observe that the message displays "Volume heal failed." even though the command
was run with insufficient arguments. This command should have ideally resulted
in a parse error as the choice of brick or file for resolution of split-brain
is not provided. Instead, it tries to heal and fails.

Version-Release number of selected component (if applicable):
--------------------------------------------------------------

glusterfs-3.7.0alpha0-0.17.gited96153.el6.x86_64

How reproducible:
------------------

Always

Steps to Reproduce:
--------------------

1. Run the command below and observe the message displayed -

# gluster v heal <vol-name> split-brain

Actual results:
-----------------

glusterfs tries to heal the file even with insufficient arguments whereas
ideally this should have resulted in a parse error.

Expected results:
------------------

Heal should not be attempted if arguments provided are incorrect or
insufficient.

Additional info:


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1186580
[Bug 1186580] QE tracker bug for Everglades
https://bugzilla.redhat.com/show_bug.cgi?id=1218570
[Bug 1218570] `gluster volume heal <vol-name> split-brain' tries to heal
even with insufficient arguments
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.