[Bugs] [Bug 1215787] [HC] qcow2 image creation using qemu-img hits segmentation fault

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1215787



--- Comment #9 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/10730 committed in release-3.7 by Niels de
Vos (ndevos at redhat.com) 
------
commit 34db0de2c12a1a802580fc308aa2f2b11a9d586f
Author: Niels de Vos <ndevos at redhat.com>
Date:   Sat May 9 19:56:07 2015 +0200

    gfapi: fix compile warning in pub_glfs_h_access()

    While compiling libgfapi, the following warning is reported:

        Making all in src
          CC       libgfapi_la-glfs-handleops.lo
        In file included from glfs-handleops.c:12:0:
        glfs-handleops.c: In function 'pub_glfs_h_access':
        glfs-internal.h:216:14: warning: 'old_THIS' may be used uninitialized
in this function [-Wmaybe-uninitialized]
                 THIS = old_THIS;                                            \
                      ^
        glfs-internal.h:202:36: note: 'old_THIS' was declared here
         #define DECLARE_OLD_THIS xlator_t *old_THIS = NULL
                                            ^
        glfs-handleops.c:1159:2: note: in expansion of macro 'DECLARE_OLD_THIS'
          DECLARE_OLD_THIS;
          ^
          CCLD     libgfapi.la
          CCLD     api.la

    The DECLARE_OLD_THIS macro should be done with the declarations of all
    the other variables used in this function. Moving the macro further up
    in the function prevents this warning.

    Backport of:
    > Change-Id: I2bedc1aa074893ae3e2c933abc5a167ab5b55f41
    > BUG: 1210934
    > Reviewed-on: http://review.gluster.org/10728
    > Reported-by: Shyamsundar Ranganathan <srangana at redhat.com>
    > Signed-off-by: Niels de Vos <ndevos at redhat.com>

    Change-Id: I2bedc1aa074893ae3e2c933abc5a167ab5b55f41
    BUG: 1215787
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/10730
    Reviewed-by: Shyamsundar Ranganathan <srangana at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=kPvadYBWUB&a=cc_unsubscribe