[Bugs] [Bug 1220050] New: Data Tiering:UI:when a user looks for detach-tier help, instead command seems to be getting executed

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1220050

            Bug ID: 1220050
           Summary: Data Tiering:UI:when a user looks for detach-tier
                    help, instead command seems to be getting executed
           Product: GlusterFS
           Version: 3.7.0
         Component: tiering
          Keywords: Triaged
          Severity: medium
          Priority: urgent
          Assignee: bugs at gluster.org
          Reporter: rkavunga at redhat.com
        QA Contact: bugs at gluster.org
                CC: amukherj at redhat.com, bugs at gluster.org,
                    nchilaka at redhat.com, rkavunga at redhat.com
        Depends On: 1211570
            Blocks: 1186580 (qe_tracker_everglades), 1199352
                    (glusterfs-3.7.0)



+++ This bug was initially created as a clone of Bug #1211570 +++

Description of problem:
======================
When a user wants to see detach-tier command help, instead of showing the usage
or how to execute, the command seems to be executing

Eg:
[root at yarrow ~]# gluster v detach-tier
Volume detach-tier failed


It should rather behave like how it is for a attach-tier

[root at yarrow ~]# gluster v attach-tier
Usage: volume attach-tier <VOLNAME> [<replica COUNT>] <NEW-BRICK>...



Version-Release number of selected component (if applicable):
============================================================
[root at yarrow ~]# gluster --version
glusterfs 3.7dev built on Apr  8 2015 17:57:45
Repository revision: git://git.gluster.com/glusterfs.git
Copyright (c) 2006-2011 Gluster Inc. <http://www.gluster.com>
GlusterFS comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of GlusterFS under the terms of the GNU General
Public License.
[root at yarrow ~]# rpm -qa|grep gluster
glusterfs-cli-3.7dev-0.994.gitf522001.el6.x86_64
glusterfs-server-3.7dev-0.994.gitf522001.el6.x86_64
glusterfs-libs-3.7dev-0.994.gitf522001.el6.x86_64
glusterfs-fuse-3.7dev-0.994.gitf522001.el6.x86_64
glusterfs-3.7dev-0.994.gitf522001.el6.x86_64
glusterfs-api-3.7dev-0.994.gitf522001.el6.x86_64



How reproducible:
=================
always and easily


Steps to Reproduce:
==================
1.just issue a "Gluster v detach-tier" command and it will say detach-tier
failed rather than showing the usage.

Expected results:
================
Show the usage as below :
[root at yarrow ~]#gluster v detach-tier
Usage:volume detach-tier <VOLNAME> - detach tier from volume <VOLNAME>

--- Additional comment from Mohammed Rafi KC on 2015-04-23 07:18:53 EDT ---

upstream patch : http://review.gluster.org/#/c/10303/

--- Additional comment from Anand Avati on 2015-04-27 03:11:25 EDT ---

REVIEW: http://review.gluster.org/10303 (cli/tiering : Parse detach-tier
command properly) posted (#2) for review on master by mohammed rafi  kc
(rkavunga at redhat.com)

--- Additional comment from Anand Avati on 2015-04-30 09:54:46 EDT ---

COMMIT: http://review.gluster.org/10303 committed in master by Kaleb KEITHLEY
(kkeithle at redhat.com) 
------
commit 508eb854f3f94f52d4ebd050f3e45deb9cfa90c8
Author: Mohammed Rafi KC <rkavunga at redhat.com>
Date:   Mon Apr 27 12:33:06 2015 +0530

    cli/tiering : Parse detach-tier command properly

    gluster detach-tier help should show the usage of
    detach-tier command properly.

    Also, instead of force option, if any other was given,
    then the command should fail with a usage message

    Change-Id: Ie801529176db067c98fd1bfada056cbc647973fb
    BUG: 1211570
    Signed-off-by: Mohammed Rafi KC <rkavunga at redhat.com>
    Reviewed-on: http://review.gluster.org/10303
    Tested-by: NetBSD Build System
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-by: Dan Lambright <dlambrig at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1186580
[Bug 1186580] QE tracker bug for Everglades
https://bugzilla.redhat.com/show_bug.cgi?id=1199352
[Bug 1199352] GlusterFS 3.7.0 tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1211570
[Bug 1211570] Data Tiering:UI:when a user looks for detach-tier help,
instead command seems to be getting executed
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.