[Bugs] [Bug 1220020] New: status.brick memory allocation failure.

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1220020

            Bug ID: 1220020
           Summary: status.brick memory allocation failure.
           Product: GlusterFS
           Version: 3.7.0
         Component: glusterd
          Keywords: Triaged
          Severity: medium
          Priority: medium
          Assignee: bugs at gluster.org
          Reporter: hchiramm at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
        Depends On: 1211594



+++ This bug was initially created as a clone of Bug #1211594 +++

Description of problem:

At current stage, there is no memory allocation failure check on status.brick
which can cause issues later in the error path. 


status.brick = GF_CALLOC (1, PATH_MAX + 256, gf_common_mt_strdup);
switch (cmd & GF_CLI_STATUS_MASK) 

{    switch (cmd & GF_CLI_STATUS_MASK) {
....

Version-Release number of selected component (if applicable):

GlusterFS 3.6.2

How reproducible:

N/A

Steps to Reproduce:

N/A

Actual results:

The memory allocation success/failure is not respected in current code.


Expected results:

The proper error code has to be returned if there is a failure.

Additional info:

--- Additional comment from Anand Avati on 2015-04-14 14:38:01 EDT ---

REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not
enough memory) posted (#4) for review on master by Humble Devassy Chirammal
(humble.devassy at gmail.com)

--- Additional comment from Anand Avati on 2015-04-15 03:20:32 EDT ---

REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not
enough memory) posted (#5) for review on master by Humble Devassy Chirammal
(humble.devassy at gmail.com)

--- Additional comment from Anand Avati on 2015-04-15 12:21:05 EDT ---

REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not
enough memory) posted (#6) for review on master by Humble Devassy Chirammal
(humble.devassy at gmail.com)

--- Additional comment from Anand Avati on 2015-04-15 23:43:57 EDT ---

REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not
enough memory) posted (#7) for review on master by Humble Devassy Chirammal
(humble.devassy at gmail.com)

--- Additional comment from Anand Avati on 2015-04-16 12:36:53 EDT ---

REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not
enough memory) posted (#8) for review on master by Humble Devassy Chirammal
(humble.devassy at gmail.com)

--- Additional comment from Anand Avati on 2015-04-17 00:39:14 EDT ---

REVIEW: http://review.gluster.org/10144 (cli: Error out when there is not
enough memory) posted (#9) for review on master by Humble Devassy Chirammal
(humble.devassy at gmail.com)

--- Additional comment from Anand Avati on 2015-04-25 10:26:46 EDT ---

COMMIT: http://review.gluster.org/10144 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit f6e24fc54453669f3943e50f44cce9bb6070a71a
Author: Humble Devassy Chirammal <hchiramm at redhat.com>
Date:   Tue Apr 7 11:27:19 2015 +0530

    cli: Error out when there is not enough memory

    Change-Id: Ia8d061de5be1343cc10a945f6cf011686a770d33
    BUG: 1211594
    Signed-off-by: Humble Devassy Chirammal <hchiramm at redhat.com>
    Reviewed-on: http://review.gluster.org/10144
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Tested-by: NetBSD Build System
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>

--- Additional comment from Anand Avati on 2015-05-08 23:30:44 EDT ---

REVIEW: http://review.gluster.org/10674 (cli: Error out when there is not
enough memory) posted (#2) for review on release-3.7 by Humble Devassy
Chirammal (humble.devassy at gmail.com)


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1211594
[Bug 1211594] status.brick memory allocation failure.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.