[Bugs] [Bug 1218936] New: marker: inode_path is being called on the inodes not yet linked

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1218936

            Bug ID: 1218936
           Summary: marker: inode_path is being called on the inodes not
                    yet linked
           Product: Red Hat Gluster Storage
           Version: 2.1
         Component: gluster-quota
          Keywords: Triaged
          Severity: high
          Assignee: vagarwal at redhat.com
          Reporter: spandit at redhat.com
        QA Contact: storage-qa-internal at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com,
                    iesool at 163.com, ndevos at redhat.com, rabhat at redhat.com,
                    vmallika at redhat.com
        Depends On: 1176393
            Blocks: 1174170, 1174250, 1138646, 1174247, 1189792
             Group: redhat



+++ This bug was initially created as a clone of Bug #1176393 +++

Description of problem:

in marker_readdirp_cbk inode_path is being called on the inodes that are not
yet linked to the inode table. If glusterfs was built with DDEBUG, then it
leads to process being asserted. Otherwise, building loc for xattr operation
fails and might cause problems.

        list_for_each_entry (entry, &entries->list, list) {
        if ((strcmp (entry->d_name, ".") == 0) ||
                    (strcmp (entry->d_name, "..") == 0))
                        continue;

                ret = marker_inode_loc_fill (entry->inode,
                                             entry->d_name, &loc);
                if (ret) {
                        gf_log (this->name, GF_LOG_WARNING, "Couln't build "
                                "loc for %s/%s",
                                uuid_utoa (local->loc.inode->gfid),
                                entry->d_name);
                    continue;
                }

            mq_xattr_state (this, &loc, entry->dict, entry->d_stat);

        loc_wipe (&loc);
    }


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2014-12-21 11:33:20 EST ---

REVIEW: http://review.gluster.org/9320 (features/marker: do not call inode_path
on the inode not yet linked) posted (#1) for review on master by Raghavendra
Bhat (raghavendra at redhat.com)

--- Additional comment from Lalatendu Mohanty on 2015-01-21 00:56:52 EST ---



--- Additional comment from Anand Avati on 2015-01-21 03:43:10 EST ---

REVIEW: http://review.gluster.org/9320 (features/marker: do not call inode_path
on the inode not yet linked) posted (#2) for review on master by Raghavendra
Bhat (raghavendra at redhat.com)

--- Additional comment from Niels de Vos on 2015-01-23 06:17:53 EST ---



--- Additional comment from Anand Avati on 2015-01-24 00:59:34 EST ---

COMMIT: http://review.gluster.org/9320 committed in master by Raghavendra G
(rgowdapp at redhat.com) 
------
commit becdb76238c45ebe3edc967376f4aee87c0cb6e3
Author: Raghavendra Bhat <raghavendra at redhat.com>
Date:   Sun Dec 21 22:01:03 2014 +0530

    features/marker: do not call inode_path on the inode not yet linked

    * in readdirp callbak marker is calling inode_path on the inodes that
      are not yet linked to the inode table.

    Change-Id: I7f5db29c6a7e778272044f60f8e73c60574df3a9
    BUG: 1176393
    Signed-off-by: Raghavendra Bhat <raghavendra at redhat.com>
    Reviewed-on: http://review.gluster.org/9320
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>
    Tested-by: Raghavendra G <rgowdapp at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1138646
[Bug 1138646] Normal operation generating error logs from marker.so
https://bugzilla.redhat.com/show_bug.cgi?id=1174170
[Bug 1174170] Glusterfs outputs a lot of warnings and errors when quota is
enabled
https://bugzilla.redhat.com/show_bug.cgi?id=1174247
[Bug 1174247] Glusterfs outputs a lot of warnings and errors when quota is
enabled
https://bugzilla.redhat.com/show_bug.cgi?id=1174250
[Bug 1174250] Glusterfs outputs a lot of warnings and errors when quota is
enabled
https://bugzilla.redhat.com/show_bug.cgi?id=1176393
[Bug 1176393] marker: inode_path is being called on the inodes not yet
linked
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Tl3Fbf3vrc&a=cc_unsubscribe