[Bugs] [Bug 1218575] New: Snapshot-scheduling helper script errors out while running "snap_scheduler.py init"

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1218575

            Bug ID: 1218575
           Summary: Snapshot-scheduling helper script errors out while
                    running "snap_scheduler.py init"
           Product: GlusterFS
           Version: 3.7.0
         Component: snapshot
          Severity: high
          Assignee: bugs at gluster.org
          Reporter: rjoseph at redhat.com
                CC: asengupt at redhat.com, bugs at gluster.org,
                    dnarayan at redhat.com, gluster-bugs at redhat.com
        Depends On: 1214574



+++ This bug was initially created as a clone of Bug #1214574 +++

Description of problem:
"snap_scheduler.py init" fails with following traceback:

Traceback (most recent call last):
  File "/usr/sbin/snap_scheduler.py", line 574, in <module>
    sys.exit(main())
  File "/usr/sbin/snap_scheduler.py", line 555, in main
    ret = perform_operation(args)
  File "/usr/sbin/snap_scheduler.py", line 408, in perform_operation
    ret = initialise_scheduler()
  File "/usr/sbin/snap_scheduler.py", line 349, in initialise_scheduler
    os.rename("/tmp/crontab", GCRON_UPDATE_TASK)
OSError: [Errno 18] Invalid cross-device link


Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:
snap_scheduler.py init fails with traceback.

Expected results:
snapshot scheduler has to be initialized properly by running the script.

Additional info:

--- Additional comment from Anand Avati on 2015-04-23 03:20:37 EDT ---

REVIEW: http://review.gluster.org/10347 (snapshot/scheduler: Use a .tmp file in
/etc/cron.d instead of /tmp) posted (#1) for review on master by Avra Sengupta
(asengupt at redhat.com)

--- Additional comment from Anand Avati on 2015-04-23 04:28:47 EDT ---

REVIEW: http://review.gluster.org/10347 (snapshot/scheduler: Use a .tmp file in
/etc/cron.d instead of /tmp) posted (#2) for review on master by Avra Sengupta
(asengupt at redhat.com)

--- Additional comment from Anand Avati on 2015-04-29 02:39:15 EDT ---

REVIEW: http://review.gluster.org/10347 (snapshot/scheduler: Use shutil.move
instead of os.rename()) posted (#3) for review on master by Avra Sengupta
(asengupt at redhat.com)

--- Additional comment from Anand Avati on 2015-04-29 03:57:48 EDT ---

REVIEW: http://review.gluster.org/10347 (snapshot/scheduler: Use shutil.move
instead of os.rename()) posted (#4) for review on master by Avra Sengupta
(asengupt at redhat.com)

--- Additional comment from Anand Avati on 2015-04-30 04:28:18 EDT ---

COMMIT: http://review.gluster.org/10347 committed in master by Krishnan
Parthasarathi (kparthas at redhat.com) 
------
commit 0be5e3d7c580f77f3db0d4282d2ac81071ccd3f5
Author: Avra Sengupta <asengupt at redhat.com>
Date:   Wed Apr 29 12:02:05 2015 +0530

    snapshot/scheduler: Use shutil.move instead of os.rename()

    os.rename is a wrapper on top of the rename function,
    which fails with invalid cross-device link if /tmp
    is a tmpfs. Hence using shutil.move

    Change-Id: Ia026d2a810b725ccd398db895e612c53bc6a2f95
    BUG: 1214574
    Signed-off-by: Avra Sengupta <asengupt at redhat.com>
    Reviewed-on: http://review.gluster.org/10347
    Reviewed-by: Rajesh Joseph <rjoseph at redhat.com>
    Reviewed-by: Aravinda VK <avishwan at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1214574
[Bug 1214574] Snapshot-scheduling helper script errors out while running
"snap_scheduler.py init"
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.