[Bugs] [Bug 1218032] New: Effect of Trash translator over CTR translator

Mon May 4 05:03:16 UTC 2015

https://bugzilla.redhat.com/show_bug.cgi?id=1218032

            Bug ID: 1218032
           Summary: Effect of Trash translator over CTR translator
           Product: GlusterFS
           Version: 3.7.0
         Component: tiering
          Severity: medium
          Priority: medium
          Assignee: bugs at gluster.org
          Reporter: achiraya at redhat.com
        QA Contact: bugs at gluster.org
                CC: achiraya at redhat.com, bugs at gluster.org,
                    dlambrig at redhat.com, gluster-bugs at redhat.com,
                    josferna at redhat.com, jthottan at redhat.com,
                    vbellur at redhat.com
        Depends On: 1205545

+++ This bug was initially created as a clone of Bug #1205545 +++

Description of problem:

Trash translator is just above posix.If it is on and unlink happens, then trash
translator redirect unlink call to rename. So the CTR will record wrong
information about the file, i.e trash translator should update CTR the file has
been removed  

Version-Release number of selected component (if applicable):
mainline

How reproducible:
Everytime

Steps to Reproduce:
1.
2.
3.

Actual results:

Expected results:

Additional info:

--- Additional comment from Jiffin on 2015-03-25 05:14:39 EDT ---

Also , CTR does not require to track contents of trash-directory

--- Additional comment from Anand Avati on 2015-03-25 05:40:32 EDT ---

REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator
if an unlink happens to a file) posted (#1) for review on master by jiffin tony
Thottan (jthottan at redhat.com)

--- Additional comment from Anand Avati on 2015-03-26 05:07:17 EDT ---

REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator
if an unlink happens to a file) posted (#2) for review on master by Joseph
Fernandes (josferna at redhat.com)

--- Additional comment from Anand Avati on 2015-03-26 05:09:55 EDT ---

REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator
if an unlink happens to a file) posted (#3) for review on master by Joseph
Fernandes (josferna at redhat.com)

--- Additional comment from Anand Avati on 2015-03-26 11:00:19 EDT ---

REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator
if an unlink happens to a file) posted (#4) for review on master by Joseph
Fernandes (josferna at redhat.com)

--- Additional comment from Anand Avati on 2015-03-28 03:33:49 EDT ---

REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator
if an unlink happens to a file) posted (#5) for review on master by Anoop C S
(achiraya at redhat.com)

--- Additional comment from Anand Avati on 2015-04-06 02:49:20 EDT ---

REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator
if an unlink happens to a file) posted (#6) for review on master by jiffin tony
Thottan (jthottan at redhat.com)

--- Additional comment from Anand Avati on 2015-04-06 04:37:31 EDT ---

REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator
if an unlink happens to a file) posted (#7) for review on master by jiffin tony
Thottan (jthottan at redhat.com)

--- Additional comment from Anand Avati on 2015-04-06 06:46:58 EDT ---

REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator
if an unlink happens to a file) posted (#8) for review on master by jiffin tony
Thottan (jthottan at redhat.com)

--- Additional comment from Anand Avati on 2015-04-07 00:37:34 EDT ---

REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator
if an unlink happens to a file) posted (#9) for review on master by jiffin tony
Thottan (jthottan at redhat.com)

--- Additional comment from Anand Avati on 2015-04-07 07:14:29 EDT ---

REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator
if an unlink happens to a file) posted (#10) for review on master by jiffin
tony Thottan (jthottan at redhat.com)

--- Additional comment from Anand Avati on 2015-04-23 05:13:04 EDT ---

REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator
if an unlink happens to a file) posted (#11) for review on master by Anoop C S
(achiraya at redhat.com)

--- Additional comment from Anand Avati on 2015-04-23 05:28:46 EDT ---

REVIEW: http://review.gluster.org/9989 (features/trash : Notify CTR translator
if an unlink happens to a file) posted (#12) for review on master by Anoop C S
(achiraya at redhat.com)

--- Additional comment from Anand Avati on 2015-04-24 14:07:28 EDT ---

COMMIT: http://review.gluster.org/9989 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit b72bc58ecc108a2fddbdb6f606cd86a57ca5a68f
Author: Jiffin Tony Thottan <jthottan at redhat.com>
Date:   Wed Mar 25 15:04:19 2015 +0530

    features/trash : Notify CTR translator if an unlink happens to a file

    This implementation is same as the posix_unlink_cbk() where CTR sends
    a request during a unlink to send the number of links to the inode
    and posix obliges sending it using the unwind xdata dict.
    For Trash xlator a unlink is stat + mkdir(if parent is not present)
    + rename. And hence this is handled in trash_unlink_rename_cbk().

    Change-Id: I402e83567b88e3c9fe171379693c82937af567f9
    BUG: 1205545
    Signed-off-by: Jiffin Tony Thottan <jthottan at redhat.com>
    Signed-off-by: Joseph Fernandes <josferna at redhat.com>
    Signed-off-by: Anoop C S <achiraya at redhat.com>
    Reviewed-on: http://review.gluster.org/9989
    Tested-by: NetBSD Build System
    Tested-by: Joseph Fernandes
    Reviewed-by: Joseph Fernandes
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1205545
[Bug 1205545] Effect of Trash translator over CTR translator
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.