[Bugs] [Bug 1207709] New: trash: remove_trash_path broken in the internal case

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1207709

            Bug ID: 1207709
           Summary: trash: remove_trash_path broken in the internal case
           Product: GlusterFS
           Version: mainline
         Component: trash-xlator
          Assignee: bugs at gluster.org
          Reporter: madam at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com



Description of problem:

Code inspection of the xlators/features/trash module showed that
that function remove_trash_path() does not do what it is supposed
to do.

1) Firstly, since the rem_path variable is not handed in by
   reference, the desired effect to the caller does not happen
   at all. This bug is fixed by:
   http://review.gluster.org/#/c/10064/
   (tracked as Coverity fix in bug #789278)

2) On top of that, the actual issue of this defect:
   The current code does the exact same thing in the
   cases internal == true and internal == false.
   What it is supposed to do is to remove an extra
   path component in the internal case (the "internal_op/"
   one added in the internal case by copy_trash_path().

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.