[Bugs] [Bug 1190069] Entries in indices/xattrop directory not removed appropriately

bugzilla at redhat.com bugzilla at redhat.com
Tue Mar 17 16:14:48 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=1190069



--- Comment #9 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/9714 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit c8be9af5f54aa3e42dffee4024d2915743258242
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Thu Mar 5 11:29:25 2015 +0000

    afr: remove stale index entries

    Problem:
    During pre-op phase, the index xlator
    1. Creates the entry inside .glusterfs/indices/xattrop
    2. Winds the xattrop fop to posix to mark dirty/pending changelogs.
    If the brick crashes after 1, the xattrop entry becomes stale and never
    gets removed by shd during subsequent crawls because there is nothing to
    heal (changelogs are zero).

    Though the stale entry does not get displayed in the output of 'heal
    info' command, it nevertheless stays there forever unless a new write
    transaction is performed on the file.

    Fix:
    During index self-heal if afr xattrs are found to be clean (indicated by
    ret value of 2 on a call to afr_shd_selfheal(), send a dummy
    post-op with all 0s for the xattr values, which makes the index xlator
    to unlink the stale entry.

    Change-Id: I02cb2bc937f2e3f3f3cb35d67b006664dc7ef919
    BUG: 1190069
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: http://review.gluster.org/9714
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Anuradha Talur <atalur at redhat.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    Tested-by: Pranith Kumar Karampuri <pkarampu at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=j9if3LWm8T&a=cc_unsubscribe


More information about the Bugs mailing list