[Bugs] [Bug 1194306] [AFR-V2] - Do not count files which did not need index heal in the first place as successfully healed

bugzilla at redhat.com bugzilla at redhat.com
Sat Mar 14 10:08:58 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=1194306



--- Comment #2 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/9852 committed in release-3.6 by Raghavendra
Bhat (raghavendra at redhat.com) 
------
commit bd775bf495bca79ed5fec72450cd884f5a734221
Author: Krutika Dhananjay <kdhananj at redhat.com>
Date:   Thu Feb 19 19:35:17 2015 +0530

    cluster/afr: Do not increment healed_count if no healing was performed

            Backport of: http://review.gluster.org/9713

    PROBLEM:
    When file modifications are happening while index heal is launched,
    index healer could pick up entries which appeared in indices/xattrop
    transiently during the course of the operations on the mount point, and
    do not really need any heal. This will cause index healer to keep doing
    index-heal in a loop as long as it finds this entry, by believing that
    it did successfully heal some gfids even when it didn't.

    FIX:
    afr_selfheal() now returns a 1 to indicate that it did not (need to)
    heal a given gfid. afr_shd_selfheal() will not increment healed_count
    whenever afr_selfheal() returns a 1.

    Change-Id: I9158c814419b635fac3dfe2fe40c94d1548ea4e8
    BUG: 1194306
    Signed-off-by: Krutika Dhananjay <kdhananj at redhat.com>
    Reviewed-on: http://review.gluster.org/9852
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-by: Anuradha Talur <atalur at redhat.com>
    Reviewed-by: Raghavendra Bhat <raghavendra at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=CJeE2AMxHK&a=cc_unsubscribe


More information about the Bugs mailing list