[Bugs] [Bug 1194305] [AFR-V2] - Do not count files which did not need index heal in the first place as successfully healed

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 5 00:38:00 UTC 2015


--- Comment #8 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/9713 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
commit 4a8384fe76aeef652554c48df737d3178eb0160c
Author: Krutika Dhananjay <kdhananj at redhat.com>
Date:   Thu Feb 19 19:35:17 2015 +0530

    cluster/afr: Do not increment healed_count if no healing was performed

    When file modifications are happening while index heal is launched,
    index healer could pick up entries which appeared in indices/xattrop
    transiently during the course of the operations on the mount point, and
    do not really need any heal. This will cause index healer to keep doing
    index-heal in a loop as long as it finds this entry, by believing that
    it did successfully heal some gfids even when it didn't.

    afr_selfheal() now returns a 1 to indicate that it did not (need to)
    heal a given gfid. afr_shd_selfheal() will not increment healed_count
    whenever afr_selfheal() returns a 1.

    Change-Id: I0d97e11392a032a852e8c6508f691300ef0e5b98
    BUG: 1194305
    Signed-off-by: Krutika Dhananjay <kdhananj at redhat.com>
    Reviewed-on: http://review.gluster.org/9713
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    Tested-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    Reviewed-by: Ravishankar N <ravishankar at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>

You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=opDxadcamI&a=cc_unsubscribe

More information about the Bugs mailing list