[Bugs] [Bug 1174017] Unchecked buffer fill by gf_readline in gf_history_changelog_next_change

bugzilla at redhat.com bugzilla at redhat.com
Wed Mar 4 12:43:48 UTC 2015


--- Comment #3 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/9275 committed in master by Venky Shankar
(vshankar at redhat.com) 
commit 80ebd3a25ae7dcfcaebec58d7a80b919e2eed5ee
Author: Niels de Vos <ndevos at redhat.com>
Date:   Sun Dec 14 21:33:17 2014 +0100

    changelog:  Unchecked buffer fill in gf_history_changelog_next_change

    A gf_history_changelog_next_change() calls gf_readline() to fill a
    buffer without checking buffer size. The size of maxlen is not verified
    to be less than the lenght of buffer. This could result in the over
    filling of buffer of maxlen is greater than PATH_MAX.

    Check the size of maxlen to be less than PATH_MAX and return a fail code
    as needed.

    BUG: 1174017
    Change-Id: Ic53b1a6e25af69a339bc15fb2d233dc1e457910f
    Reported-by: Keith Schincke <kschinck at redhat.com>
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/9275
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Venky Shankar <vshankar at redhat.com>
    Tested-by: Venky Shankar <vshankar at redhat.com>

You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=89MOF5xLJr&a=cc_unsubscribe

More information about the Bugs mailing list