[Bugs] [Bug 1198427] New: cmd log history should not be a hidden file

Wed Mar 4 05:39:26 UTC 2015

https://bugzilla.redhat.com/show_bug.cgi?id=1198427

            Bug ID: 1198427
           Summary: cmd log history should not be a hidden file
           Product: Red Hat Storage
           Version: 3.0
         Component: doc-Administration_Guide
     Sub Component: Default
          Keywords: Patch, Triaged, ZStream
          Severity: high
          Priority: high
          Assignee: storage-doc at redhat.com
          Reporter: psriniva at redhat.com
        QA Contact: storage-qa-internal at redhat.com
                CC: amukherj at redhat.com, asriram at redhat.com,
                    asrivast at redhat.com, bugs at gluster.org,
                    gluster-bugs at redhat.com, kaushal at redhat.com,
                    lmohanty at redhat.com, mhideo at redhat.com,
                    nlevinki at redhat.com, nsathyan at redhat.com,
                    rcyriac at redhat.com, rhs-bugs at redhat.com,
                    rwheeler at redhat.com, sasundar at redhat.com,
                    vbellur at redhat.com
        Depends On: 1165996, 1181051
            Blocks: 1182947
             Group: redhat

+++ This bug was initially created as a clone of Bug #1181051 +++

+++ This bug was initially created as a clone of Bug #1165996 +++

Description of problem:
all cli commands history are written in a file called .cmd_log_history which is
hidden and there is no need of having it as hidden. Recently while capturing
the state of the node, sosreport didn't capture this file as its hidden,
probably its an enhancement to sosreport.

Version-Release number of selected component (if applicable):
Mainline

--- Additional comment from Anand Avati on 2014-11-20 03:38:25 EST ---

REVIEW: http://review.gluster.org/9150 (cli: .cmd_log_history should not be
hidden) posted (#1) for review on master by Atin Mukherjee
(amukherj at redhat.com)

--- Additional comment from Anand Avati on 2014-11-20 23:48:35 EST ---

REVIEW: http://review.gluster.org/9150 (cli: .cmd_log_history should not be
hidden) posted (#2) for review on master by Atin Mukherjee
(amukherj at redhat.com)

--- Additional comment from Anand Avati on 2014-11-25 02:36:25 EST ---

COMMIT: http://review.gluster.org/9150 committed in master by Kaushal M
(kaushal at redhat.com) 
------
commit c6f27ed5cc9a6fafc6e6f83aff00196bc7a49d38
Author: Atin Mukherjee <amukherj at redhat.com>
Date:   Thu Nov 20 14:06:03 2014 +0530

    cli: .cmd_log_history should not be hidden

    Change-Id: I4513a2c260530855e09be64083e9344108c7a6c0
    BUG: 1165996
    Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-on: http://review.gluster.org/9150
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Kaushal M <kaushal at redhat.com>

--- Additional comment from SATHEESARAN on 2015-01-20 05:07:30 EST ---

This bug falls under MUST_FIX category for RHS 3.0.4, as the
/var/log/glusterfs/.cmd_log_history was not added to sosreports as its a hidden
file. The fix for this bug would make this file __not__ hidden and thereby
sosreport could pick that file in its report.

This bug could be verified for RHS 3.0.4 and providing the qa_ack.

--- Additional comment from Atin Mukherjee on 2015-01-28 23:26:15 EST ---

Downstream patch link : https://code.engineering.redhat.com/gerrit/#/c/40894/

--- Additional comment from SATHEESARAN on 2015-02-11 22:04:33 EST ---

The file /var/log/glusterfs/.cmd_log_history was no longer a hidden file as I
tested with glusterfs-3.4.0.44-1.el6rhs
Now the new file with the name - /var/log/glusterfs/cmd_history.log -  was
created.

The system that was being upgraded from RHS 3.0.3 to RHS 3.0.4 is having 2
files now. one is /var/log/glusterfs/.cmd_log-history other is
/var/log/glusterfs/cmd_history.log

In such a case continuity of logs will be lost. 

So avoid this scenario, post install script should do the following :

if (new-installation of Red Hat Gluster Storage Server ):
    no-action-required
if( upgrade-to-3.0.4 or higher )
    rename /var/log/glusterfs/.cmd_log_history
/var/log/glusterfs/cmd_history.log

It was decided in the sync-up meeting to track this change with this bug
Moving the state of bug to assigned.

--- Additional comment from SATHEESARAN on 2015-02-11 22:09:12 EST ---

Removing the FailedQA Tag, as it actually not failed QE Verification , but
re-opened for enhancement that would facilitate to get all command history in a
single file

--- Additional comment from Atin Mukherjee on 2015-02-18 01:23:10 EST ---

Downstream patch link : https://code.engineering.redhat.com/gerrit/#/c/42150/

--- Additional comment from SATHEESARAN on 2015-02-23 06:13:58 EST ---

Verified with glusterfs-3.6.0.46-1.el6rhs with 2 test scenarios,
1. Upgrading from RHS 3.0.3 to RHS 3.0.4 nightly
In this case, previously existing /var/log/glusterfs/.cmd_log_history was
renamed to /var/log/glusterfs/cmd_history.log

2. Installing a fresh RHS 3.0.4 nightly rpms
In this case, a new file /var/log/glusterfs/cmd_history.log file was created

Marking this bug as VERIFIED

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1165996
[Bug 1165996] cmd log history should not be a hidden file
https://bugzilla.redhat.com/show_bug.cgi?id=1181051
[Bug 1181051] cmd log history should not be a hidden file
https://bugzilla.redhat.com/show_bug.cgi?id=1182947
[Bug 1182947] Tracker bug for 3.0.4
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sxakitAYVV&a=cc_unsubscribe