[Bugs] [Bug 1236274] New: Upcall: Directory or file creation should send cache invalidation requests to parent directories

Sat Jun 27 06:44:26 UTC 2015

https://bugzilla.redhat.com/show_bug.cgi?id=1236274

            Bug ID: 1236274
           Summary: Upcall: Directory or file creation should send cache
                    invalidation requests to parent directories
           Product: GlusterFS
           Version: 3.7.2
         Component: upcall
          Severity: urgent
          Assignee: bugs at gluster.org
          Reporter: skoduri at redhat.com
        Depends On: 1235542
            Blocks: 1235543, 1235544

+++ This bug was initially created as a clone of Bug #1235542 +++

Description of problem:
Any directory or file creation should result in cache-invalidation requests
sent to parent directory. However that is not the case currently due to a bug
while processing these requests in the upcall xlator. We need to do
invalidation checks on parent inode.

--- Additional comment from Anand Avati on 2015-06-25 03:10:51 EDT ---

REVIEW: http://review.gluster.org/11387 (Upcall: Fix an issue with invalidating
parent entries) posted (#2) for review on master by soumya k
(skoduri at redhat.com)

--- Additional comment from Anand Avati on 2015-06-25 06:43:28 EDT ---

REVIEW: http://review.gluster.org/11387 (Upcall: Fix an issue with invalidating
parent entries) posted (#3) for review on master by soumya k
(skoduri at redhat.com)

--- Additional comment from Anand Avati on 2015-06-25 10:18:49 EDT ---

REVIEW: http://review.gluster.org/11387 (Upcall: Fix an issue with invalidating
parent entries) posted (#4) for review on master by soumya k
(skoduri at redhat.com)

--- Additional comment from Anand Avati on 2015-06-25 10:38:30 EDT ---

REVIEW: http://review.gluster.org/11411 (protocol/server: Include a check to
validate xprt->client) posted (#1) for review on master by soumya k
(skoduri at redhat.com)

--- Additional comment from Anand Avati on 2015-06-26 06:19:15 EDT ---

REVIEW: http://review.gluster.org/11411 (protocol/server: Include a check to
validate xprt->client) posted (#3) for review on master by soumya k
(skoduri at redhat.com)

--- Additional comment from Anand Avati on 2015-06-26 07:32:25 EDT ---

REVIEW: http://review.gluster.org/11411 (protocol/server: Include a check to
validate xprt->client) posted (#4) for review on master by soumya k
(skoduri at redhat.com)

--- Additional comment from Anand Avati on 2015-06-26 21:12:53 EDT ---

COMMIT: http://review.gluster.org/11387 committed in master by Kaleb KEITHLEY
(kkeithle at redhat.com) 
------
commit 35d24f0c967130ef8424660b5f6dfd182bb305c1
Author: Soumya Koduri <skoduri at redhat.com>
Date:   Thu Jun 25 00:47:19 2015 +0530

    Upcall: Fix an issue with invalidating parent entries

    Any directory or file creation should result in cache-invalidation
    requests sent to parent directory. However that is not the case
    currently due to a bug while processing these requests in the
    upcall xlator. We need to do invalidation checks on parent inode.

    Fixed the same. Also fixed an issue with null client entries while
    sending upcall notifications.

    Change-Id: I3da7c79091291ba36fd8f8ebcfebcd77a192f250
    BUG: 1235542
    Signed-off-by: Soumya Koduri <skoduri at redhat.com>
    Reviewed-on: http://review.gluster.org/11387
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-by: Meghana M <mmadhusu at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>

--- Additional comment from Anand Avati on 2015-06-26 21:15:03 EDT ---

COMMIT: http://review.gluster.org/11411 committed in master by Kaleb KEITHLEY
(kkeithle at redhat.com) 
------
commit 14cf2bbe77fbbaee8ee3211ec841a4f1ef3a8380
Author: Soumya Koduri <skoduri at redhat.com>
Date:   Thu Jun 25 19:49:59 2015 +0530

    protocol/server: Include a check to validate xprt->client

    rpc_transport entries(xprt) are added to the conf->xprt_list
    during client connection with the server. But the client object is created
    and assigned to that transport object only during GF_HANDSK_SETVOLUME.
Hence
    till that period, there could be xprt entries in the xprt_list without
client
    associated with it. Added a check to validate the client object during
upcall
    notify.

    Change-Id: I11e2fcd8b0a67e35302ede478b777b72d1973456
    BUG: 1235542
    Signed-off-by: Soumya Koduri <skoduri at redhat.com>
    Reviewed-on: http://review.gluster.org/11411
    Reviewed-by: Krishnan Parthasarathi <kparthas at redhat.com>
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>

--- Additional comment from Anand Avati on 2015-06-27 02:43:10 EDT ---

REVIEW: http://review.gluster.org/11440 (Upcall: Fix an issue with invalidating
parent entries) posted (#1) for review on release-3.7 by soumya k
(skoduri at redhat.com)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1235542
[Bug 1235542] Upcall: Directory or file creation should send cache
invalidation requests to parent directories
https://bugzilla.redhat.com/show_bug.cgi?id=1235543
[Bug 1235543] Upcall: Directory or file creation should send cache
invalidation requests to parent directories
https://bugzilla.redhat.com/show_bug.cgi?id=1235544
[Bug 1235544] Upcall: Directory or file creation should send cache
invalidation requests to parent directories
-- 
You are receiving this mail because:
You are the assignee for the bug.