[Bugs] [Bug 1227996] Objects are not signed upon truncate()

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1227996



--- Comment #6 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/11077 committed in master by Raghavendra Bhat
(raghavendra at redhat.com) 
------
commit 8e81dccfce17db2d388de95b0b009478cc7d0d4d
Author: Venky Shankar <vshankar at redhat.com>
Date:   Thu Jun 4 10:07:38 2015 +0530

    features/bitrot: fix fd leak in truncate (stub)

    The need to perform object versioning in the truncate() code path
    required an fd to reuse existing versioning infrastructure that's
    used by fd based operations (such as writev(), ftruncate(), etc..).

    This tempted the use of anonymous fd which was never ever unref()'d
    after use resulting in fd and/or memory leak depending on the code
    path taken. Versioning resulted in a dangling file descriptor left
    open in the filesystem effecting the signing process of a given
    object (no release() would be trigerred, hence no signing would be
    performed). On the other hand, cases where the object need not be
    versioned, the anonymous fd in still ref()'d resulting in memory
    leak (NOTE: there's no "dangling" file descriptor in this case).

    Change-Id: I29c3d2af9bbc5cd4b8ddf38954080e3c7a44ba61
    BUG: 1227996
    Signed-off-by: Venky Shankar <vshankar at redhat.com>
    Reviewed-on: http://review.gluster.org/11077
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Raghavendra Bhat <raghavendra at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the Docs Contact for the bug.