[Bugs] [Bug 1231767] New: tiering:compiler warning with gcc v5.1.1

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1231767

            Bug ID: 1231767
           Summary: tiering:compiler warning with gcc v5.1.1
           Product: GlusterFS
           Version: 3.7.0
         Component: tiering
          Keywords: Triaged
          Severity: low
          Priority: urgent
          Assignee: bugs at gluster.org
          Reporter: achiraya at redhat.com
        QA Contact: bugs at gluster.org
                CC: bugs at gluster.org, rkavunga at redhat.com
        Depends On: 1226881
            Blocks: 1229272



+++ This bug was initially created as a clone of Bug #1226881 +++

Description of problem:

gcc v5.1.1 throws warning for calling a static function from a non-static
inline function.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.compile with gcc v5.1.1
2.
3.

Actual results:

couple of compiler warning

Expected results:

should be free from compiler warning

Additional info:

--- Additional comment from Anand Avati on 2015-06-01 07:39:18 EDT ---

REVIEW: http://review.gluster.org/11032 (tiering:static function called from a
non static inline function) posted (#1) for review on master by mohammed rafi 
kc (rkavunga at redhat.com)

--- Additional comment from Mohammed Rafi KC on 2015-06-01 07:46:16 EDT ---



--- Additional comment from Anand Avati on 2015-06-02 01:30:00 EDT ---

REVIEW: http://review.gluster.org/11032 (tiering:static function called from a
non static inline function) posted (#3) for review on master by mohammed rafi 
kc (rkavunga at redhat.com)

--- Additional comment from Anand Avati on 2015-06-02 18:00:25 EDT ---

COMMIT: http://review.gluster.org/11032 committed in master by Niels de Vos
(ndevos at redhat.com) 
------
commit 3a94f4c52b56f08c326d3212ca5708e8daf8585b
Author: Mohammed Rafi KC <rkavunga at redhat.com>
Date:   Mon Jun 1 16:53:32 2015 +0530

    tiering:static function called from a non static inline function

    gcc v5.1.1 throws warning for calling a static function from a
    non-static inline function.


    <snippet from compiler warning>
      CC       tier.lo
    tier.c:610:15: warning: 'tier_migrate_using_query_file' is static but used
in inline function 'tier_migrate_files_using_qfile' which is not static
             ret = tier_migrate_using_query_file ((void *)query_cbk_args);
                   ^
    tier.c:585:47: warning: 'tier_process_brick_cbk' is static but used in
inline function 'tier_build_migration_qfile' which is not static
             ret = dict_foreach (args->brick_list, tier_process_brick_cbk,
                                                   ^
    tier.c:565:176: warning: 'demotion_qfile' is static but used in inline
function 'tier_build_migration_qfile' which is not static
    tier.c:565:158: warning: 'promotion_qfile' is static but used in inline
function 'tier_build_migration_qfile' which is not static
    tier.c:563:58: warning: 'demotion_qfile' is static but used in inline
function 'tier_build_migration_qfile' which is not static
    tier.c:563:40: warning: 'promotion_qfile' is static but used in inline
function 'tier_build_migration_qfile' which is not static
             ret = remove (GET_QFILE_PATH (is_promotion));
                                            ^
      CCLD     tier.la

    </snip>

    Change-Id: I46046feeb79ab4e2724b0ba6b02c9ec8b121ff4e
    BUG: 1226881
    Signed-off-by: Mohammed Rafi KC <rkavunga at redhat.com>
    Reviewed-on: http://review.gluster.org/11032
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-by: Anoop C S <achiraya at redhat.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1226881
[Bug 1226881] tiering:compiler warning with gcc v5.1.1
https://bugzilla.redhat.com/show_bug.cgi?id=1229272
[Bug 1229272] tiering:compiler warning with gcc v5.1.1
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.
You are the assignee for the bug.