[Bugs] [Bug 1230691] New: [geo-rep]: use_meta_volume config option should be validated for its values

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1230691

            Bug ID: 1230691
           Summary: [geo-rep]: use_meta_volume config option should be
                    validated for its values
           Product: GlusterFS
           Version: 3.7.0
         Component: geo-replication
          Severity: medium
          Assignee: bugs at gluster.org
          Reporter: avishwan at redhat.com
                CC: aavati at redhat.com, avishwan at redhat.com,
                    bugs at gluster.org, csaba at redhat.com,
                    gluster-bugs at redhat.com, nlevinki at redhat.com,
                    nsathyan at redhat.com, rhinduja at redhat.com,
                    storage-qa-internal at redhat.com
        Depends On: 1227618, 1230090
            Blocks: 1223636



+++ This bug was initially created as a clone of Bug #1230090 +++

+++ This bug was initially created as a clone of Bug #1227618 +++

Description of problem:
=======================

use_meta_volume config option should be True/False, On/Off, 0/1,
enable/disable. But currently it accepts all the values for example:


[root at georep1 scripts]# gluster volume geo-replication master
10.70.46.154::slave config use_meta_volume xyz
geo-replication config updated successfully
[root at georep1 scripts]# gluster volume geo-replication master
10.70.46.154::slave config use_meta_volume
xyz
[root at georep1 scripts]# gluster volume geo-replication master
10.70.46.154::slave config use_meta_volume 0123
geo-replication config updated successfully
[root at georep1 scripts]# gluster volume geo-replication master
10.70.46.154::slave config use_meta_volume
0123
[root at georep1 scripts]# gluster volume geo-replication master
10.70.46.154::slave config \!use_meta_volume 
geo-replication config updated successfully
[root at georep1 scripts]# gluster volume geo-replication master
10.70.46.154::slave config use_meta_volume
[root at georep1 scripts]# 


Version-Release number of selected component (if applicable):
==============================================================

glusterfs-3.7.0-3.el6rhs.x86_64

How reproducible:
=================

Always


Steps to Reproduce:
===================
1. gluster volume geo-replication master 10.70.46.154::slave config
use_meta_volume xyz

Actual results:
===============

[root at georep1 scripts]# gluster volume geo-replication master
10.70.46.154::slave config use_meta_volume xyz
geo-replication config updated successfully
[root at georep1 scripts]#

Expected results:
=================


[root at georep1 scripts]# gluster volume geo-replication master
10.70.46.154::slave config use_meta_volume xyz
Invalid value(xyz) for option use_meta_volume
geo-replication command failed
[root at georep1 scripts]#

--- Additional comment from Aravinda VK on 2015-06-10 04:49:47 EDT ---

Upstream patch sent
http://review.gluster.org/#/c/11156/

--- Additional comment from Anand Avati on 2015-06-10 12:45:04 EDT ---

REVIEW: http://review.gluster.org/11156 (geo-rep: Validate use_meta_volume
option) posted (#2) for review on master by Aravinda VK (avishwan at redhat.com)

--- Additional comment from Anand Avati on 2015-06-11 02:40:51 EDT ---

REVIEW: http://review.gluster.org/11156 (geo-rep: Validate use_meta_volume
option) posted (#3) for review on master by Aravinda VK (avishwan at redhat.com)


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1223636
[Bug 1223636] 3.1 QE Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1227618
[Bug 1227618] [geo-rep]: use_meta_volume config option should be validated
for its values
https://bugzilla.redhat.com/show_bug.cgi?id=1230090
[Bug 1230090] [geo-rep]: use_meta_volume config option should be validated
for its values
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.