[Bugs] [Bug 1230018] New: [SNAPSHOT]: Initializing snap_scheduler from all nodes at the same time should give proper error message

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1230018

            Bug ID: 1230018
           Summary: [SNAPSHOT]: Initializing snap_scheduler from all nodes
                    at the same time should give proper error message
           Product: GlusterFS
           Version: 3.7.1
         Component: snapshot
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: asengupt at redhat.com
                CC: amukherj at redhat.com, bugs at gluster.org,
                    gluster-bugs at redhat.com, senaik at redhat.com
        Depends On: 1218060
            Blocks: 1186580 (qe_tracker_everglades), 1224249, 1223203



+++ This bug was initially created as a clone of Bug #1218060 +++

Description of problem:
=======================
Initialising snap_scheduler from all nodes at the same time should fail with
proper error message - "Another snap scheduler command is running"

Version-Release number of selected component (if applicable):
==============================================================
glusterfs 3.7.0beta1 built on May  1 2015

How reproducible:
=================
always

Steps to Reproduce:
===================
1.Create a dist rep volume and mount it.

2.Create another shared storage volume and mount it under
/var/run/gluster/shared_storage

3.Initialise snap scheduler at the same time from all nodes 

NOde1: 
~~~~~
snap_scheduler.py init
snap_scheduler: Successfully inited snapshot scheduler for this node

Node2, Node3, Node4 : 
~~~~~~~~~~~~~~~~~~~~
snap_scheduler.py init
Traceback (most recent call last):
  File "/usr/sbin/snap_scheduler.py", line 574, in <module>
    sys.exit(main())
  File "/usr/sbin/snap_scheduler.py", line 544, in main
    os.makedirs(LOCK_FILE_DIR)
  File "/usr/lib64/python2.6/os.py", line 157, in makedirs
    mkdir(name, mode)
OSError: [Errno 17] File exists:
'/var/run/gluster/shared_storage/snaps/lock_files/'

It should fail with error : 
snap_scheduler: Another snap_scheduler command is running. Please try again
after some time.

Actual results:


Expected results:


Additional info:

--- Additional comment from  on 2015-05-20 01:17:37 EDT ---

Same issue seen while checking snap_scheduler.py status from all nodes at the
same time 

Node1:
======
snap_scheduler.py status
snap_scheduler: Snapshot scheduling status: Disabled

Node2,Node3, Node4:
===================
 snap_scheduler.py status
Traceback (most recent call last):
  File "/usr/sbin/snap_scheduler.py", line 575, in <module>
    sys.exit(main())
  File "/usr/sbin/snap_scheduler.py", line 545, in main
    os.makedirs(LOCK_FILE_DIR)
  File "/usr/lib64/python2.6/os.py", line 157, in makedirs
    mkdir(name, mode)
OSError: [Errno 17] File exists:
'/var/run/gluster/shared_storage/snaps/lock_files/'

--- Additional comment from Anand Avati on 2015-06-04 07:48:45 EDT ---

REVIEW: http://review.gluster.org/11087 (snapshot/scheduler: Handle OSError in
os. callbacks) posted (#1) for review on master by Avra Sengupta
(asengupt at redhat.com)

--- Additional comment from Anand Avati on 2015-06-10 02:40:59 EDT ---

COMMIT: http://review.gluster.org/11087 committed in master by Krishnan
Parthasarathi (kparthas at redhat.com) 
------
commit d835219a30327ede60e4ef28210914ab30bd0712
Author: Avra Sengupta <asengupt at redhat.com>
Date:   Thu Jun 4 17:17:13 2015 +0530

    snapshot/scheduler: Handle OSError in os. callbacks

    Handle OSError and not IOError in os. callbacks.

    Change-Id: I2b5bfb629bacbd2d2e410d96034b4e2c11c4931e
    BUG: 1218060
    Signed-off-by: Avra Sengupta <asengupt at redhat.com>
    Reviewed-on: http://review.gluster.org/11087
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Aravinda VK <avishwan at redhat.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1186580
[Bug 1186580] QE tracker bug for Everglades
https://bugzilla.redhat.com/show_bug.cgi?id=1218060
[Bug 1218060] [SNAPSHOT]: Initializing snap_scheduler from all nodes at the
same time should give proper error message
https://bugzilla.redhat.com/show_bug.cgi?id=1223203
[Bug 1223203] [SNAPSHOT]: Initializing snap_scheduler from all nodes at the
same time should give proper error message
https://bugzilla.redhat.com/show_bug.cgi?id=1224249
[Bug 1224249] [SNAPSHOT]: Initializing snap_scheduler from all nodes at the
same time should give proper error message
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.