[Bugs] [Bug 1227916] auth_cache_entry structure barely gets cached

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1227916



--- Comment #1 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/11075 committed in release-3.7 by Niels de
Vos (ndevos at redhat.com) 
------
commit cccd1e3cce7873e873c7266af703f4f77ff4c679
Author: Niels de Vos <ndevos at redhat.com>
Date:   Wed Jun 3 21:53:37 2015 +0200

    nfs: allocate and return the hashkey for the auth_cache_entry

    The allocation of the hashkey was never returned to the calling
    function.

    Allocating it with alloca() puts it on the stack, returning from the
    function makes the pointer invalid. Functions that are annotated with
    "inline" and call alloca(), will not always be inlined. Returning a
    pointer allocated with alloca() is in those cases not correct. One such
    confirmation was provided by GCC developer Alexandre Oliva:
     - http://gcc.gnu.org/ml/gcc-help/2004-04/msg00158.html

    It is more correct to call GF_MALLOC() and GF_FREE() for the hashkey. If
    this would result in preformance hit, we can always think of using
    alloca() again and turn make_hashkey() into a macro (yuck).

    Cherry picked from commit b8b59fea7822f9ab1e10d7a3f730354fe82a6097:
    > Change-Id: Ia86a1f79d33240af4713bfb92f702b0ee6e87eb7
    > BUG: 1226714
    > Signed-off-by: Niels de Vos <ndevos at redhat.com>
    > Reviewed-on: http://review.gluster.org/11019
    > Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    > Reviewed-by: jiffin tony Thottan <jthottan at redhat.com>
    > Reviewed-by: soumya k <skoduri at redhat.com>
    > Tested-by: Gluster Build System <jenkins at build.gluster.com>

    Change-Id: Ia86a1f79d33240af4713bfb92f702b0ee6e87eb7
    BUG: 1227916
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/11075
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: jiffin tony Thottan <jthottan at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qIutCGm2gF&a=cc_unsubscribe