[Bugs] [Bug 1229248] New: Data Tiering:UI:changes required to CLI responses for attach and detach tier

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1229248

            Bug ID: 1229248
           Summary: Data Tiering:UI:changes required to CLI responses for
                    attach and detach tier
           Product: Red Hat Gluster Storage
           Version: 3.1
         Component: glusterfs
     Sub Component: tiering
          Keywords: Triaged
          Severity: medium
          Priority: urgent
          Assignee: rhs-bugs at redhat.com
          Reporter: nchilaka at redhat.com
        QA Contact: nchilaka at redhat.com
                CC: amukherj at redhat.com, annair at redhat.com,
                    bugs at gluster.org, josferna at redhat.com,
                    rkavunga at redhat.com
        Depends On: 1211562
            Blocks: 1186580 (qe_tracker_everglades), 1220052



+++ This bug was initially created as a clone of Bug #1211562 +++

Description of problem:
======================
The response user gets after executing a attach-tier or detach-tier right now
are quite ambigous. They talk about brick rather than the tier.
Eg: on a attach tier it says "add-brick is success"
[root at yarrow ~]# gluster v attach-tier ec_vol1 yarrow:/yarrow_ssd_75G_2/ec_vol1
rhs-client6:/brick15/ec_vol1 force
volume add-brick: success
[root at yarrow ~]# gluster v info ec_vol1


It should instead say, attaching of tier to <volname> is successful


same with detach tier, it say remove-brick is success

Need to take care even when the command fails, like it should be detach-tier
fails rather than remove-brick fails


Version-Release number of selected component (if applicable):
============================================================
[root at yarrow ~]# gluster --version
glusterfs 3.7dev built on Apr  8 2015 17:57:45
Repository revision: git://git.gluster.com/glusterfs.git
Copyright (c) 2006-2011 Gluster Inc. <http://www.gluster.com>
GlusterFS comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of GlusterFS under the terms of the GNU General
Public License.
[root at yarrow ~]# rpm -qa|grep gluster
glusterfs-cli-3.7dev-0.994.gitf522001.el6.x86_64
glusterfs-server-3.7dev-0.994.gitf522001.el6.x86_64
glusterfs-libs-3.7dev-0.994.gitf522001.el6.x86_64
glusterfs-fuse-3.7dev-0.994.gitf522001.el6.x86_64
glusterfs-3.7dev-0.994.gitf522001.el6.x86_64
glusterfs-api-3.7dev-0.994.gitf522001.el6.x86_64



How reproducible:
=================
always and easily


Steps to Reproduce:
==================
1.create a regular volume
2.attach a tier, the reponse user gets talks abt brick rather than tier
3.same with detaching the tier

--- Additional comment from Anand Avati on 2015-04-17 05:01:13 EDT ---

REVIEW: http://review.gluster.org/10284 (cli/tiering: Enhance cli output for
tiering) posted (#1) for review on master by mohammed rafi  kc
(rkavunga at redhat.com)

--- Additional comment from Anand Avati on 2015-05-02 08:15:10 EDT ---

REVIEW: http://review.gluster.org/10284 (cli/tiering: Enhance cli output for
tiering) posted (#2) for review on master by mohammed rafi  kc
(rkavunga at redhat.com)

--- Additional comment from Anand Avati on 2015-05-08 18:12:26 EDT ---

REVIEW: http://review.gluster.org/10284 (cli/tiering: Enhance cli output for
tiering) posted (#5) for review on master by mohammed rafi  kc
(rkavunga at redhat.com)

--- Additional comment from Anand Avati on 2015-05-09 00:27:57 EDT ---

COMMIT: http://review.gluster.org/10284 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit 2676c402bc47ee89b763393e496a013e82d76e54
Author: Mohammed Rafi KC <rkavunga at redhat.com>
Date:   Sat May 2 17:31:07 2015 +0530

    cli/tiering: Enhance cli output for tiering

    Fix for handling cli output for attach-tier and
    detach-tier

    Change-Id: I4d17f4b09612754fe1b8cec6c2e14927029b9678
    BUG: 1211562
    Signed-off-by: Mohammed Rafi KC <rkavunga at redhat.com>
    Reviewed-on: http://review.gluster.org/10284
    Reviewed-by: Dan Lambright <dlambrig at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Tested-by: NetBSD Build System
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>

--- Additional comment from Niels de Vos on 2015-05-15 09:07:34 EDT ---

This change should not be in "ON_QA", the patch posted for this bug is only
available in the master branch and not in a release yet. Moving back to
MODIFIED until there is an beta release for the next GlusterFS version.

--- Additional comment from Niels de Vos on 2015-05-18 02:41:39 EDT ---


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1186580
[Bug 1186580] QE tracker bug for Everglades
https://bugzilla.redhat.com/show_bug.cgi?id=1211562
[Bug 1211562] Data Tiering:UI:changes required to CLI responses for attach
and detach tier
https://bugzilla.redhat.com/show_bug.cgi?id=1220052
[Bug 1220052] Data Tiering:UI:changes required to CLI responses for attach
and detach tier
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9ZbHDXnBV9&a=cc_unsubscribe