[Bugs] [Bug 1228640] New: afr: unrecognized option in re-balance volfile

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1228640

            Bug ID: 1228640
           Summary: afr: unrecognized option in re-balance volfile
           Product: GlusterFS
           Version: 3.7.0
         Component: replicate
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: ravishankar at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com,
                    pkarampu at redhat.com, ravishankar at redhat.com,
                    rkavunga at redhat.com
        Depends On: 1225328



+++ This bug was initially created as a clone of Bug #1225328 +++

Description of problem:

Rebalance process logs a warning for some of the option defined in afr
translator saying that option is unrecognized. 

Version-Release number of selected component (if applicable):


How reproducible:

100%

Steps to Reproduce:
1.create and start a volume
2.start rebalance process
3.

Actual results:

a warning in log for unrecognized options in volfile

Expected results:

should not be any unrecognized options

Additional info:

--- Additional comment from Mohammed Rafi KC on 2015-05-27 02:59:52 EDT ---

<snip from log>

[2015-05-27 06:42:15.673134] I [dht-shared.c:598:dht_init] 0-patchy2-hot-dht:
dht_init using commit hash 2871736852
[2015-05-27 06:42:15.675759] I [dht-shared.c:598:dht_init] 0-patchy2-cold-dht:
dht_init using commit hash 2871736852
[2015-05-27 06:42:15.678491] W [graph.c:357:_log_if_unknown_option]
0-patchy2-hot-replicate-1: option 'readdir-failover' is not recognized
[2015-05-27 06:42:15.678535] W [graph.c:357:_log_if_unknown_option]
0-patchy2-hot-replicate-0: option 'readdir-failover' is not recognized
[2015-05-27 06:42:15.678562] W [graph.c:357:_log_if_unknown_option]
0-patchy2-cold-replicate-1: option 'readdir-failover' is not recognized
[2015-05-27 06:42:15.678578] W [graph.c:357:_log_if_unknown_option]
0-patchy2-cold-replicate-0: option 'readdir-failover' is not recognized
[2015-05-27 06:42:15.678645] I [client.c:2154:notify] 0-patchy2-client-0:
parent translators are ready, attempting connect on transport
[2015-05-27 06:42:15.677862] I [event-epoll.c:629:event_dispatch_epoll_worker]
0-epoll: Started thread with index 2


</snip>

--- Additional comment from Anand Avati on 2015-05-27 04:45:31 EDT ---

REVIEW: http://review.gluster.org/10935 (glusterd/ afr: remove the
readdir-failover option) posted (#1) for review on master by Ravishankar N
(ravishankar at redhat.com)

--- Additional comment from Anand Avati on 2015-06-05 07:25:27 EDT ---

COMMIT: http://review.gluster.org/10935 committed in master by Krishnan
Parthasarathi (kparthas at redhat.com) 
------
commit 02ccab9257ab36af281a4a610684a913dfa32d0f
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Fri May 29 10:40:22 2015 +0530

    glusterd/ afr: remove the readdir-failover option from rebalance process

    Remove the "replicate*.readdir-failover=off" xlator option from
    rebalance process' runner arguments because this is the default behaviour
in
    afr-v2. i.e. reaaddir failover happens only if it is a new readdir
    (offset=0). 'Continuing'readdirs are always wound on the same child
    where the first readdir had happened and if that child is down, the
    readdir fails.

    The option cannot be removed from glusterd_volopt_map because there is a
    chance of ending up in peer rejected state in a heterogenous cluster
    (typical upgrade scenario) due to volinfo checksum mismatch. TODO:come up
with
    some warning message to the user for such deprecated options if a volume
    set is attempted.

    Change-Id: I6a33dc9fae7cccea8c5fd3d9de40d88d13ad3689
    BUG: 1225328
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: http://review.gluster.org/10935
    Reviewed-by: Krutika Dhananjay <kdhananj at redhat.com>
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    Reviewed-by: Anuradha Talur <atalur at redhat.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1225328
[Bug 1225328] afr: unrecognized option in re-balance volfile
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.