[Bugs] [Bug 1228045] New: Scrubber should be disabled once bitrot is reset

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1228045

            Bug ID: 1228045
           Summary: Scrubber should be disabled once bitrot is reset
           Product: GlusterFS
           Version: 3.7.0
         Component: bitrot
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: ggarg at redhat.com
                CC: bugs at gluster.org, rmekala at redhat.com
        Depends On: 1220713
      Docs Contact: bugs at gluster.org



+++ This bug was initially created as a clone of Bug #1220713 +++

Description of problem:
=================================
Scrubber should be disabled once bitrot is reset 


Version-Release number of selected component (if applicable):
======================================
glusterfs-server-3.7.0beta1-0.69.git1a32479.el6.x86_64


How reproducible:
======================
always 


Steps to Reproduce:
======================
1.Enable bitrot on volume as part of this both bitd and scrub demons will be
started 
2.using gluster vol reset command reset bitrot, but only bitrot is reset to
default (disable) and still scrubber is active state 

root at rhs-client37 beta2]# gluster vol reset ECVOL bitrot
volume reset: failed: 'features.bitrot' is protected. To reset use 'force'.
[root at rhs-client37 beta2]# gluster vol reset ECVOL bitrot force
volume reset: success: reset volume successful
[root at rhs-client37 beta2]# gluster vol info ECVOL

Volume Name: ECVOL
Type: Disperse
Volume ID: f8f88610-17fb-4db5-9ced-4dcb215d8e2c
Status: Started
Number of Bricks: 1 x (4 + 2) = 6
Transport-type: tcp
Bricks:
Brick1: 10.70.33.235:/rajesh3/brick7
Brick2: 10.70.33.235:/rajesh3/brick8
Brick3: 10.70.33.235:/rajesh3/brick9
Brick4: 10.70.33.229:/rajesh3/brick7
Brick5: 10.70.33.229:/rajesh3/brick8
Brick6: 10.70.33.229:/rajesh3/brick9
Options Reconfigured:
features.scrub-throttle: aggressive
features.scrub: Active
features.uss: enable


Expected results:
========================
Scrub also should be reset to default (disable) once bitrot is reset

Additional info:

--- Additional comment from Anand Avati on 2015-05-27 05:13:18 EDT ---

REVIEW: http://review.gluster.org/10936 (bitrot/glusterd: scrub option should
be disabled once bitrot option is reset) posted (#1) for review on master by
Gaurav Kumar Garg (ggarg at redhat.com)

--- Additional comment from Anand Avati on 2015-05-28 00:54:11 EDT ---

REVIEW: http://review.gluster.org/10936 (bitrot/glusterd: scrub option should
be disabled once bitrot option is reset) posted (#2) for review on master by
Atin Mukherjee (amukherj at redhat.com)

--- Additional comment from Anand Avati on 2015-05-28 05:49:39 EDT ---

REVIEW: http://review.gluster.org/10936 (bitrot/glusterd: scrub option should
be disabled once bitrot option is reset) posted (#4) for review on master by
Gaurav Kumar Garg (ggarg at redhat.com)

--- Additional comment from Anand Avati on 2015-05-28 05:59:46 EDT ---

REVIEW: http://review.gluster.org/10936 (bitrot/glusterd: scrub option should
be disabled once bitrot option is reset) posted (#5) for review on master by
Gaurav Kumar Garg (ggarg at redhat.com)

--- Additional comment from Anand Avati on 2015-06-03 05:25:40 EDT ---

REVIEW: http://review.gluster.org/10936 (bitrot/glusterd: scrub option should
be disabled once bitrot option is reset) posted (#6) for review on master by
Gaurav Kumar Garg (ggarg at redhat.com)

--- Additional comment from Anand Avati on 2015-06-04 02:38:03 EDT ---

COMMIT: http://review.gluster.org/10936 committed in master by Venky Shankar
(vshankar at redhat.com) 
------
commit 79d8916929f7d5b85a09ae9b75eadf945a3e11fb
Author: Gaurav Kumar Garg <ggarg at redhat.com>
Date:   Wed May 27 14:36:24 2015 +0530

    bitrot/glusterd: scrub option should be disabled once bitrot option is
reset

    Scrubber options should be disabled from the dictionary if user reset
    bitrot option.

    Change-Id: Ic7e390cf88b9b749f0ada8bbd4632f4cc0c4aff9
    BUG: 1220713
    Signed-off-by: Gaurav Kumar Garg <ggarg at redhat.com>
    Reviewed-on: http://review.gluster.org/10936
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Venky Shankar <vshankar at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1220713
[Bug 1220713] Scrubber should be disabled once bitrot is reset
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are the Docs Contact for the bug.