[Bugs] [Bug 1227576] New: libglusterfs: Copy _all_ members of gf_dirent_t in entry_copy()

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1227576

            Bug ID: 1227576
           Summary: libglusterfs: Copy _all_ members of gf_dirent_t in
                    entry_copy()
           Product: GlusterFS
           Version: 3.7.0
         Component: core
          Keywords: Triaged
          Assignee: kdhananj at redhat.com
          Reporter: kdhananj at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
        Depends On: 1226551



+++ This bug was initially created as a clone of Bug #1226551 +++

Description of problem:

Per discussion @
http://review.gluster.org/#/c/10809/1/xlators/features/shard/src/shard.c, the
function entry_copy() must also copy d_len member and the per-entry dict if it
is present, into the dst dirent.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-06-01 02:41:20 EDT ---

REVIEW: http://review.gluster.org/11026 (libglusterfs: Copy d_len and dict as
well into dst dirent) posted (#1) for review on master by Krutika Dhananjay
(kdhananj at redhat.com)

--- Additional comment from Anand Avati on 2015-06-01 07:23:36 EDT ---

REVIEW: http://review.gluster.org/11026 (libglusterfs: Copy d_len and dict as
well into dst dirent) posted (#2) for review on master by Krutika Dhananjay
(kdhananj at redhat.com)

--- Additional comment from Anand Avati on 2015-06-02 09:52:38 EDT ---

REVIEW: http://review.gluster.org/11026 (libglusterfs: Copy d_len and dict as
well into dst dirent) posted (#3) for review on master by Krutika Dhananjay
(kdhananj at redhat.com)

--- Additional comment from Anand Avati on 2015-06-02 23:46:22 EDT ---

COMMIT: http://review.gluster.org/11026 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit e1d9895ba6f7763ba4602094f6516a6ab4a054d4
Author: Krutika Dhananjay <kdhananj at redhat.com>
Date:   Mon Jun 1 11:55:29 2015 +0530

    libglusterfs: Copy d_len and dict as well into dst dirent

    Also, added memory allocation failure checks in light of the
    comments received @
    http://review.gluster.org/#/c/10809/2/libglusterfs/src/gf-dirent.c, and
    http://review.gluster.org/#/c/10809/1/xlators/features/shard/src/shard.c

    Change-Id: Ie4092218545c8f4f8a0e6cc1fec6ba37bbbf2620
    BUG: 1226551
    Signed-off-by: Krutika Dhananjay <kdhananj at redhat.com>
    Reviewed-on: http://review.gluster.org/11026
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1226551
[Bug 1226551] libglusterfs: Copy _all_ members of gf_dirent_t in
entry_copy()
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WOValY9Maz&a=cc_unsubscribe