[Bugs] [Bug 1227168] New: glusterd could crash in remove-brick-status when local remove-brick process has just completed

Tue Jun 2 04:02:10 UTC 2015

https://bugzilla.redhat.com/show_bug.cgi?id=1227168

            Bug ID: 1227168
           Summary: glusterd could crash in remove-brick-status when local
                    remove-brick process has just completed
           Product: Red Hat Gluster Storage
           Version: 3.1
         Component: glusterfs-server
          Assignee: rhs-bugs at redhat.com
          Reporter: kparthas at redhat.com
        QA Contact: storage-qa-internal at redhat.com
                CC: amukherj at redhat.com, bugs at gluster.org,
                    gluster-bugs at redhat.com, nlevinki at redhat.com,
                    vbellur at redhat.com
        Depends On: 1223338, 1225318
            Blocks: 1219955 (glusterfs-3.7.1), 1223634

+++ This bug was initially created as a clone of Bug #1225318 +++

+++ This bug was initially created as a clone of Bug #1223338 +++

Description of problem:
Glusterd process could crash while executing remove-brick-status command around
the time when the local remove-brick process (i.e, rebalance process) has
completed migrating data. 

Version-Release number of selected component (if applicable):
glusterfs-3.7.0

How reproducible:
Intermittent

Steps to Reproduce:
1. Create and start a volume.
2. Add files/directories as required.
3. Remove one or more bricks using remove-brick-start command.
4. Issue remove-brick-status command around the time when the local
remove-brick
   process is completed.

Actual results:
glusterd process crashes.

Expected results:
glusterd shouldn't crash. It would be helpful if the remove-brick-status
command failed saying that the rebalance process may have just completed with
migration of data from the bricks being removed.

Additional info:
The above steps are representative of when the issue can be seen but not really
helpful if you wish to automate this. The following link leads to the
regression test, as part of GlusterFS regression test suite, that has hit this
problem more often. This could help those interested in automation.

https://github.com/gluster/glusterfs/blob/master/tests/bugs/glusterd/bug-974007.t

--- Additional comment from Anand Avati on 2015-05-21 03:11:46 EDT ---

REVIEW: http://review.gluster.org/10872 (glusterd: fix double-free of rebalance
process' rpc object) posted (#1) for review on master by Krishnan Parthasarathi
(kparthas at redhat.com)

--- Additional comment from Anand Avati on 2015-05-21 23:13:13 EDT ---

REVIEW: http://review.gluster.org/10872 (glusterd: fix double-free of rebalance
process' rpc object) posted (#2) for review on master by Krishnan Parthasarathi
(kparthas at redhat.com)

--- Additional comment from Anand Avati on 2015-05-26 05:58:45 EDT ---

REVIEW: http://review.gluster.org/10872 (glusterd: fix double-free of rebalance
process' rpc object) posted (#3) for review on master by Krishnan Parthasarathi
(kparthas at redhat.com)

--- Additional comment from Anand Avati on 2015-05-26 09:42:02 EDT ---

COMMIT: http://review.gluster.org/10872 committed in master by Kaushal M
(kaushal at redhat.com) 
------
commit f59a1431e38ad644b6bdd4adbdf94ff028c9c60d
Author: Krishnan Parthasarathi <kparthas at redhat.com>
Date:   Wed May 20 18:23:58 2015 +0530

    glusterd: fix double-free of rebalance process' rpc object

    Change-Id: I0c79c4de47a160b1ecf3a8994eedc02e3f5002a9
    BUG: 1223338
    Signed-off-by: Krishnan Parthasarathi <kparthas at redhat.com>
    Reviewed-on: http://review.gluster.org/10872
    Tested-by: NetBSD Build System
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-by: Kaushal M <kaushal at redhat.com>

--- Additional comment from Anand Avati on 2015-05-27 23:51:42 EDT ---

REVIEW: http://review.gluster.org/10932 (glusterd: fix double-free of rebalance
process' rpc object) posted (#3) for review on release-3.7 by Krishnan
Parthasarathi (kparthas at redhat.com)

--- Additional comment from Anand Avati on 2015-05-30 02:34:17 EDT ---

REVIEW: http://review.gluster.org/10932 (glusterd: fix double-free of rebalance
process' rpc object) posted (#4) for review on release-3.7 by Vijay Bellur
(vbellur at redhat.com)

--- Additional comment from Anand Avati on 2015-05-30 10:05:32 EDT ---

COMMIT: http://review.gluster.org/10932 committed in release-3.7 by Vijay
Bellur (vbellur at redhat.com) 
------
commit 0308c7a2800f52810093af780c42b6c6616c2aed
Author: Krishnan Parthasarathi <kparthas at redhat.com>
Date:   Wed May 20 18:23:58 2015 +0530

    glusterd: fix double-free of rebalance process' rpc object

    Change-Id: I0c79c4de47a160b1ecf3a8994eedc02e3f5002a9
    BUG: 1225318
    Signed-off-by: Krishnan Parthasarathi <kparthas at redhat.com>
    Reviewed-on: http://review.gluster.org/10872
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-by: Kaushal M <kaushal at redhat.com>
    Reviewed-on: http://review.gluster.org/10932
    Tested-by: NetBSD Build System
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1219955
[Bug 1219955] GlusterFS 3.7.1 tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1223338
[Bug 1223338] glusterd could crash in remove-brick-status when local
remove-brick process has just completed
https://bugzilla.redhat.com/show_bug.cgi?id=1223634
[Bug 1223634] glusterd could crash in remove-brick-status when local
remove-brick process has just completed
https://bugzilla.redhat.com/show_bug.cgi?id=1225318
[Bug 1225318] glusterd could crash in remove-brick-status when local
remove-brick process has just completed
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jhwQ0gkMa0&a=cc_unsubscribe