[Bugs] [Bug 1190633] self-heal-algorithm with option "full" doesn't heal sparse files correctly

bugzilla at redhat.com bugzilla at redhat.com
Thu Feb 12 12:09:16 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=1190633



--- Comment #5 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/9611 committed in release-3.5 by Niels de Vos
(ndevos at redhat.com) 
------
commit b6c37bd9954fb3b7aee79dbe453f875b70a03e71
Author: Ravishankar N <ravishankar at redhat.com>
Date:   Mon Feb 9 08:31:10 2015 +0530

    afr: Don't write to sparse regions of sink.

    Corresponding afr-v2 fix: http://review.gluster.org/#/c/9480/

    Problem:
    When data-self-heal-algorithm is set to 'full', shd just reads from
    source and writes to sink. If source file happened to be sparse (VM
    workloads), we end up actually writing 0s to the corresponding regions
    of the sink causing it to lose its sparseness.

    Fix:
    If the source file is sparse, and the data read from source and sink are
    both zeros for that range, skip writing that range to the sink.

    Change-Id: Iade957e4173c87e45a2881df501ba2ad3eb1a172
    BUG: 1190633
    Signed-off-by: Ravishankar N <ravishankar at redhat.com>
    Reviewed-on: http://review.gluster.org/9611
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    Reviewed-by: Krutika Dhananjay <kdhananj at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=dpon25Zkwq&a=cc_unsubscribe


More information about the Bugs mailing list