[Bugs] [Bug 1177928] Directories not visible anymore after add-brick, new brick dirs not part of old bricks
bugzilla at redhat.com
bugzilla at redhat.com
Wed Feb 11 10:15:33 UTC 2015
https://bugzilla.redhat.com/show_bug.cgi?id=1177928
--- Comment #5 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/9374 committed in release-3.5 by Niels de Vos
(ndevos at redhat.com)
------
commit bb8845d3bd94f94a1302bb50811be209a7253dcb
Author: Pranith Kumar K <pkarampu at redhat.com>
Date: Wed Dec 31 16:41:43 2014 +0530
cluster/afr: serialize inode locks
Backport of http://review.gluster.com/9372
Problem:
Afr winds inodelk calls without any order, so blocking inodelks
from two different mounts can lead to dead lock when mount1 gets
the lock on brick-1 and blocked on brick-2 where as mount2 gets
lock on brick-2 and blocked on brick-1
Fix:
Serialize the inodelks whether they are blocking inodelks or
non-blocking inodelks.
Non-blocking locks also need to be serialized.
Otherwise there is a chance that both the mounts which issued same
non-blocking inodelk may endup not acquiring the lock on any-brick.
Ex:
Mount1 and Mount2 request for full length lock on file f1. Mount1 afr may
acquire the partial lock on brick-1 and may not acquire the lock on brick-2
because Mount2 already got the lock on brick-2, vice versa. Since both the
mounts only got partial locks, afr treats them as failure in gaining the
locks
and unwinds with EAGAIN errno.
Change-Id: I939a1d101e313a9f0abf212b94cdce1392611a5e
BUG: 1177928
Signed-off-by: Pranith Kumar K <pkarampu at redhat.com>
Reviewed-on: http://review.gluster.org/9374
Reviewed-by: Krutika Dhananjay <kdhananj at redhat.com>
Tested-by: Gluster Build System <jenkins at build.gluster.com>
Reviewed-by: Niels de Vos <ndevos at redhat.com>
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OLxT0JrgRc&a=cc_unsubscribe
More information about the Bugs
mailing list