[Bugs] [Bug 1256265] Data Loss:Remove brick commit passing when remove-brick process has not even started(due to killing glusterd)

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1256265



--- Comment #2 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/11996 committed in release-3.7 by Kaushal M
(kaushal at redhat.com) 
------
commit f51ffaeda4c87b682b7865c26befd75fe1c8cb25
Author: Atin Mukherjee <amukherj at redhat.com>
Date:   Tue Jul 21 09:57:43 2015 +0530

    glusterd: Don't allow remove brick start/commit if glusterd is down of the
host of the brick

    Backport of http://review.gluster.org/#/c/11726/

    remove brick stage blindly starts the remove brick operation even if the
    glusterd instance of the node hosting the brick is down. Operationally its
    incorrect and this could result into a inconsistent rebalance status across
all
    the nodes as the originator of this command will always have the rebalance
    status to 'DEFRAG_NOT_STARTED', however when the glusterd instance on the
other
    nodes comes up, will trigger rebalance and make the status to completed
once the
    rebalance is finished.

    This patch fixes two things:
    1. Add a validation in remove brick to check whether all the peers hosting
the
    bricks to be removed are up.

    2. Don't copy volinfo->rebal.dict from stale volinfo during restore as this
    might end up in a incosistent node_state.info file resulting into volume
status
    command failure.

    Change-Id: Ia4a76865c05037d49eec5e3bbfaf68c1567f1f81
    BUG: 1256265
    Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-on: http://review.gluster.org/11726
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: N Balachandran <nbalacha at redhat.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas at redhat.com>
    Reviewed-on: http://review.gluster.org/11996
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Kaushal M <kaushal at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=gNHC3xu4Pj&a=cc_unsubscribe