[Bugs] [Bug 1257193] New: protocol server : Pending - porting log messages to a new framework

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1257193

            Bug ID: 1257193
           Summary: protocol server : Pending - porting log messages to a
                    new framework
           Product: GlusterFS
           Version: 3.7.3
         Component: logging
          Severity: medium
          Assignee: bugs at gluster.org
          Reporter: mselvaga at redhat.com
                CC: annair at redhat.com, bugs at gluster.org,
                    gluster-bugs at redhat.com, mselvaga at redhat.com,
                    sasundar at redhat.com
        Depends On: 1242269, 1252808
            Blocks: 1241957



+++ This bug was initially created as a clone of Bug #1252808 +++

+++ This bug was initially created as a clone of Bug #1242269 +++

Description of problem:
-----------------------
There are few instances of gf_log and gf_log_callingfn seen under protocol
server component under the code base.
These needs to be ported in to new logging framework

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
RHGS 3.1 Nightly build ( glusterfs-3.7.1-8.el6rhs )


Additional info:
----------------
Here are the instances of gf_log :
[satheesaran at dhcppc1 server]$ grep -r "gf_log " * -A1
src/server-rpc-fops.c:  gf_log (this->name, GF_LOG_INFO,
src/server-rpc-fops.c-         "%"PRId64": IPC%"PRId64" (%s) ==> (%s)",
--
src/server.c:  gf_log (this->name, GF_LOG_WARNING,
src/server.c-       "Received invalid upcall event(%d)",
--
src/server.c:  gf_log (this->name, GF_LOG_ERROR,
src/server.c-       "server_process_event_upcall failed");

Here are the instances of gf_log_callingfn:
[satheesaran at dhcppc1 server]$ grep -r "gf_log_callingfn " * -A1
src/server.c:                        gf_log_callingfn (THIS->name,
GF_LOG_ERROR,
src/server.c-                                          "Failed to get iobuf");
--
src/server.c:                        gf_log_callingfn ("", GF_LOG_ERROR,
"Failed to encode message");
src/server.c-                        req->rpc_err = GARBAGE_ARGS;
--
src/server.c:                gf_log_callingfn ("", GF_LOG_ERROR, "Reply
submission failed");
src/server.c-                if (frame && client && !lk_heal) {
--
src/server.c:                        gf_log_callingfn ("", GF_LOG_ERROR,
src/server.c-                                          "Reply submission
failed");
--
src/server.c:                gf_log_callingfn ("server", GF_LOG_WARNING,
src/server.c-                                  "Calling rpc_notify without
initializing");
--
src/server.c:                gf_log_callingfn (this->name, GF_LOG_DEBUG, "conf
== null!!!");
src/server.c-                goto out;

--- Additional comment from Anand Avati on 2015-08-13 07:02:38 EDT ---

REVIEW: http://review.gluster.org/11895 (protocol/server : porting missing
gf_log's to gf_msg) posted (#3) for review on master by Manikandan Selvaganesh
(mselvaga at redhat.com)

--- Additional comment from Anand Avati on 2015-08-17 07:07:32 EDT ---

REVIEW: http://review.gluster.org/11895 (protocol/server : porting missing
gf_log's to gf_msg) posted (#4) for review on master by Manikandan Selvaganesh
(mselvaga at redhat.com)

--- Additional comment from Anand Avati on 2015-08-20 03:01:36 EDT ---

REVIEW: http://review.gluster.org/11895 (protocol/server : porting missing
gf_log's to gf_msg) posted (#6) for review on master by Manikandan Selvaganesh
(mselvaga at redhat.com)

--- Additional comment from Anand Avati on 2015-08-24 03:29:45 EDT ---

REVIEW: http://review.gluster.org/11895 (protocol/server : porting missing
gf_log's to gf_msg) posted (#7) for review on master by Manikandan Selvaganesh
(mselvaga at redhat.com)

--- Additional comment from Anand Avati on 2015-08-26 07:11:13 EDT ---

REVIEW: http://review.gluster.org/11895 (protocol/server : porting missing
gf_log's to gf_msg) posted (#8) for review on master by Manikandan Selvaganesh
(mselvaga at redhat.com)

--- Additional comment from Anand Avati on 2015-08-26 08:08:27 EDT ---

COMMIT: http://review.gluster.org/11895 committed in master by Raghavendra G
(rgowdapp at redhat.com) 
------
commit a26dbb38acdb2ec5fe16068caee189709faae76e
Author: Manikandan Selvaganesh <mselvaga at redhat.com>
Date:   Wed Aug 12 15:29:31 2015 +0530

    protocol/server : porting missing gf_log's to gf_msg

    Change-Id: I8818931fafea3c013551a5de23a9f77c81164841
    BUG: 1252808
    Signed-off-by: Manikandan Selvaganesh <mselvaga at redhat.com>
    Reviewed-on: http://review.gluster.org/11895
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1241957
[Bug 1241957] [ TRACKER ] : Tracker for porting pending log messages
porting to new framework
https://bugzilla.redhat.com/show_bug.cgi?id=1242269
[Bug 1242269] protocol server : Pending - porting log messages to a new
framework
https://bugzilla.redhat.com/show_bug.cgi?id=1252808
[Bug 1252808] protocol server : Pending - porting log messages to a new
framework
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.