[Bugs] [Bug 1256606] New: all: Make all the xlator fops static to avoid incorrect symbol resolution

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1256606

            Bug ID: 1256606
           Summary: all: Make all the xlator fops static to avoid
                    incorrect symbol resolution
           Product: GlusterFS
           Version: 3.7.3
         Component: unclassified
          Keywords: Triaged
          Severity: medium
          Assignee: bugs at gluster.org
          Reporter: skoduri at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com,
                    kkeithle at redhat.com
        Depends On: 1248669
            Blocks: 1256485, 1216951



+++ This bug was initially created as a clone of Bug #1248669 +++

Description of problem:

As described in the bug1245636, we have encountered an issue where in the
'snapview-client' xlator lookup fop name 'svc_lookup' matches with one of the
routines provided by libntirpc, used by NFS-Ganesha. Hence while using 'uss'
feature over NFS-Ganesha, during dlopen() of the snapview-client xlator, as 
'svc_lookup' is already loaded, 'xlator->fops->lookup' incorrectly refers to
that symbol.

To avoid similar issues, it would be better and cleaner to mark all the xlator
fops static. This bug is to track all the required changes.

--- Additional comment from Soumya Koduri on 2015-07-31 03:07:59 EDT ---



--- Additional comment from Anand Avati on 2015-07-31 05:02:54 EDT ---

REVIEW: http://review.gluster.org/11805 (snapshot: Make fops static for correct
resolution of symbols) posted (#3) for review on master by soumya k
(skoduri at redhat.com)

--- Additional comment from Anand Avati on 2015-08-04 08:54:22 EDT ---

REVIEW: http://review.gluster.org/11814 (build: export minimum symbols from
xlators for correct resolution) posted (#21) for review on master by Kaleb
KEITHLEY (kkeithle at redhat.com)

--- Additional comment from Anand Avati on 2015-08-24 13:23:13 EDT ---

COMMIT: http://review.gluster.org/11805 committed in master by Niels de Vos
(ndevos at redhat.com) 
------
commit d5e03b7f02f68b3a9aaccf586e1f6ed901224ba7
Author: Soumya Koduri <skoduri at redhat.com>
Date:   Thu Jul 30 16:37:45 2015 +0530

    snapshot: Make fops static for correct resolution of symbols

    Few of the snapshot fops (like 'svc_lookup') may not get resolved
    while using dynamic loading as there could be other libraries(like
libntirpc)
    with same routine names. Making them static to resolve the same.

    Change-Id: I6577bf3705864f5583425c94427b4e1025a59bcd
    BUG: 1248669
    Signed-off-by: Soumya Koduri <skoduri at redhat.com>
    Reviewed-on: http://review.gluster.org/11805
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Rajesh Joseph <rjoseph at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1248669
[Bug 1248669] all: Make all the xlator fops static to avoid incorrect
symbol resolution
https://bugzilla.redhat.com/show_bug.cgi?id=1256485
[Bug 1256485] [Snapshot]/[NFS-Ganesha] mount point hangs upon snapshot
create-activate and 'cd' into .snaps directory
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.