https://bugzilla.redhat.com/show_bug.cgi?id=1255351
Bug ID: 1255351
Summary: fail the fops if inode context get fails
Product: GlusterFS
Version: 3.7.3
Component: bitrot
Assignee: bugs at gluster.org
Reporter: rabhat at redhat.com
CC: bugs at gluster.org
Depends On: 1243391
Docs Contact: bugs at gluster.org
+++ This bug was initially created as a clone of Bug #1243391 +++
Description of problem:
Some fops such as readv, writev, open etc checks if the object is bad or not by
getting the info from the inode context. If the inode_context_get operation
fails, then bit-rot-stub still allows the fops to go through.
It should fail the fop if inode context could not be obtained.
Version-Release number of selected component (if applicable):
How reproducible:
Steps to Reproduce:
1.
2.
3.
Actual results:
Expected results:
Additional info:
--- Additional comment from Anand Avati on 2015-07-15 07:25:57 EDT ---
REVIEW: http://review.gluster.org/11449 (features/bit-rot-stub: fail the fop if
inode context get fails) posted (#4) for review on master by Raghavendra Bhat
(raghavendra at redhat.com)
--- Additional comment from Anand Avati on 2015-07-24 08:51:12 EDT ---
REVIEW: http://review.gluster.org/11449 (features/bit-rot-stub: fail the fop if
inode context get fails) posted (#5) for review on master by Raghavendra Bhat
(raghavendra at redhat.com)
--- Additional comment from Anand Avati on 2015-08-05 03:33:04 EDT ---
REVIEW: http://review.gluster.org/11449 (features/bit-rot-stub: fail the fop if
inode context get fails) posted (#6) for review on master by Raghavendra Bhat
(raghavendra at redhat.com)
--- Additional comment from Anand Avati on 2015-08-12 00:18:05 EDT ---
COMMIT: http://review.gluster.org/11449 committed in master by Venky Shankar
(vshankar at redhat.com)
------
commit 7b44b6c16fb538e5f15a255182de4dee781994a0
Author: Raghavendra Bhat <raghavendra at redhat.com>
Date: Sat Jun 27 13:17:32 2015 +0530
features/bit-rot-stub: fail the fop if inode context get fails
In stub, for fops like readv, writev etc, if the the object is bad, then
the fop
is denied. But for checking if the object is bad inode context should be
checked. Now, if the inode context is not there, then the fop is allowed to
continue. This patch fixes it and the fop is unwound with an error, if the
inode
context is not found.
Change-Id: I5ea4d4fc1a91387f7f9d13ca8cb43c88429f02b0
BUG: 1243391
Signed-off-by: Raghavendra Bhat <raghavendra at redhat.com>
Reviewed-on: http://review.gluster.org/11449
Tested-by: NetBSD Build System <jenkins at build.gluster.org>
Reviewed-by: Venky Shankar <vshankar at redhat.com>
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1243391
[Bug 1243391] fail the fops if inode context get fails
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are the Docs Contact for the bug.