[Bugs] [Bug 1240991] Quota: After rename operation , gluster v quota <volname> list-objects command give incorrect no. of files in output

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1240991



--- Comment #18 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/11578 committed in master by Raghavendra G
(rgowdapp at redhat.com) 
------
commit 4efc8ea17f8452cf5a5f3a504419c1269d332d79
Author: vmallika <vmallika at redhat.com>
Date:   Sun Jul 12 08:49:49 2015 +0530

    quota/marker: fix inode quota with rename

    There are three problems with marker-rename which
    is fixed in this patch

    Problem 1)
    1) mq_reduce_parent_size is not handling inode-quota contribution
    2) When dest files exists and IO is happening
       Now renaming will overwrite existing file
       mq_reduce_parent_size called on dest file
       with saved contribution, this can be
       a problem is IO is still happening
       contribution might have changed

    Problem 2)
    There is a small race between rename and in-progress write
    Consider below scenario
    1) rename FOP invoked on file 'x'
    2) write is still in progress for file 'x'
    3) rename takes a lock on old-parent
    4) write-update txn blocked on old-parent to acquire lock
    5) in rename_cbk, contri xattrs are removed and contribution is deleted and
       lock is released
    6) now write-update txn gets the lock and updates the wrong parent
       as it was holding lock on old parent
       so validate parent once the lock is acquired

    Problem 3)
    when a rename operation is performed, a lock is
    held on old parent. This lock is release before
    unwinding the rename operation.
    This can be a problem if there are in-progress
    writes happening during rename, where update txn
    can take a lock and update the old parent
    as inode table is not updated with new parent

    Change-Id: Ic3316097c001c33533f98592e8fcf234b1ee2aa2
    BUG: 1240991
    Signed-off-by: vmallika <vmallika at redhat.com>
    Reviewed-on: http://review.gluster.org/11578
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9Tjn2LDqzL&a=cc_unsubscribe