[Bugs] [Bug 1254607] New: rpc: Address issues with transport object reference and leak

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1254607

            Bug ID: 1254607
           Summary: rpc: Address issues with transport object reference
                    and leak
           Product: GlusterFS
           Version: 3.7.3
         Component: rpc
          Assignee: bugs at gluster.org
          Reporter: skoduri at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
        Depends On: 1250797



+++ This bug was initially created as a clone of Bug #1250797 +++

Description of problem:

We have seen a couple of issues with transport object reference and leak in rpc
layer, particularly with 'rpc_clnt_disable', 

a) Once the transport object is disassociated from rpc->conn, it should not be 
referenced further. Fix is needed in 'rpc_clnt_remove_ping_timer_locked'.

b) Unref transport object to avoid memory leak.

--- Additional comment from Anand Avati on 2015-08-08 06:50:48 EDT ---

COMMIT: http://review.gluster.org/11845 committed in master by Kaleb KEITHLEY
(kkeithle at redhat.com) 
------
commit 6e8c137fb7deca75817d617d40ebd58bbcae186a
Author: Soumya Koduri <skoduri at redhat.com>
Date:   Thu Aug 6 06:22:38 2015 +0530

    rpc-clnt: Check for transport object during rpc connection cleanup

    While doing glfs_fini(), all the xlators are first notified of
    PARENT_DOWN. protocol-client xlator on receving that notification
    does rpc_clnt_disable which disassociates rpc->conn with its
    transport object and does socket shutdown. So any further references
    to conn->trans should not happen during rpc connection cleanup which
    is done mainly as part of epoll event handling of EPOLLERR/EPOLLHUP.

    BUG: 1250797
    Change-Id: I7d0346451d40372ad59a6a2326176fbb1e694712
    Signed-off-by: Soumya Koduri <skoduri at redhat.com>
    Reviewed-on: http://review.gluster.org/11845
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1250797
[Bug 1250797] rpc: Address issues with transport object reference and leak
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.