[Bugs] [Bug 1254436] New: logging: Revert usage of global xlator for log buffer

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1254436

            Bug ID: 1254436
           Summary: logging:  Revert usage of global xlator for log buffer
           Product: GlusterFS
           Version: 3.7.3
         Component: logging
          Keywords: Triaged
          Severity: high
          Assignee: bugs at gluster.org
          Reporter: skoduri at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com,
                    jdarcy at redhat.com, kdhananj at redhat.com,
                    nbalacha at redhat.com, pgurusid at redhat.com
        Depends On: 1243806
            Blocks: 1241761



+++ This bug was initially created as a clone of Bug #1243806 +++

Description of problem:
With http://review.gluster.org/#/c/10319/, global_xlator is used for
allocations needed for logging so that we don't try to free objects belonging
to an already-deleted translator (which will crash). The same global xlator
needs to be referred while trying to free those allocations as well.

--- Additional comment from Anand Avati on 2015-07-16 07:48:56 EDT ---

REVIEW: http://review.gluster.org/11696 (logging: Use global xlator to free log
buffer) posted (#1) for review on master by soumya k (skoduri at redhat.com)

--- Additional comment from Anand Avati on 2015-08-05 23:31:21 EDT ---

REVIEW: http://review.gluster.org/11811 (Revert "core: avoid crashes in gf_msg
dup-detection code") posted (#3) for review on master by soumya k
(skoduri at redhat.com)

--- Additional comment from Soumya Koduri on 2015-08-05 23:37:17 EDT ---

Instead, since with http://review.gluster.org/#/c/10417/, struct mem_accnt is
no longer embedded in a xlator_t object, but allocated separately, we have
decided to revert the workaround provided to avoid crashes in logging
infrastructure.

--- Additional comment from Anand Avati on 2015-08-06 04:50:36 EDT ---

REVIEW: http://review.gluster.org/11811 (logging: Stop using global xlator for
log_buf allocations) posted (#4) for review on master by soumya k
(skoduri at redhat.com)

--- Additional comment from Anand Avati on 2015-08-08 06:51:28 EDT ---

COMMIT: http://review.gluster.org/11811 committed in master by Kaleb KEITHLEY
(kkeithle at redhat.com) 
------
commit 3e05e2c69979119ca63b1ae5b775019d8bd27d31
Author: Soumya Koduri <skoduri at redhat.com>
Date:   Thu Jul 30 17:03:50 2015 +0530

    logging: Stop using global xlator for log_buf allocations

    This reverts commit 765849ee00f6661c9059122ff2346b03b224745f.

    With http://review.gluster.org/#/c/10417/, struct mem_accnt
    is no longer embedded in a xlator_t object, but instead is
    allocated separately. Hence this workaround provided to avoid
    crashes in logging infrastructure is no longer needed

    BUG: 1243806
    Change-Id: I1bc006172ebe5e417a5923f8be2f37a6277c5e5d
    Signed-off-by: Soumya Koduri <skoduri at redhat.com>
    Reviewed-on: http://review.gluster.org/11811
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: N Balachandran <nbalacha at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1241761
[Bug 1241761] nfs-ganesha: coredump "pthread_spin_lock () from
/lib64/libpthread.so.0"
https://bugzilla.redhat.com/show_bug.cgi?id=1243806
[Bug 1243806] logging:  Revert usage of global xlator for log buffer
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.