[Bugs] [Bug 1252297] Quota: volume-reset shouldn't remove quota-deem-statfs, unless explicitly specified, when quota is enabled.

bugzilla at redhat.com bugzilla at redhat.com
Wed Aug 12 11:46:58 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=1252297



--- Comment #3 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/11879 committed in release-3.7 by Raghavendra
G (rgowdapp at redhat.com) 
------
commit 13061c8006471c87ff92007c8decc5586c600f0f
Author: Manikandan Selvaganesh <mselvaga at redhat.com>
Date:   Wed Aug 5 19:23:01 2015 +0530

    quota : volume-reset shouldn't remove quota-deem-statfs

    Volume-reset shouldn't remove quota-deem-statfs, unless
    explicitly specified, when quota is enabled.

    1) glusterd_op_stage_reset_volume ()
       'gluster volume set/reset <VOLNAME>' features.quota/
       features.inode-quota' should not be allowed as it is deprecated.
       Setting and resetting quota/inode-quota features should be allowed
       only through 'gluster volume quota <VOLNAME> enable/disable'.

    2) glusterd_enable_default_options ()
       Option 'features.quota-deem-statfs' should not be turned off
       with 'gluster volume reset <VOLNAME>', since quota features
       can be set/reset only with 'gluster volume quota <VOLNAME>
       enable/disable'.

    But, 'gluster volume set features.quota-deem-statfs'
    can be turned on/off when quota is enabled.

            Backport of http://review.gluster.org/#/c/11839/

    Cherry picked from commit 1868be8a5c309da8d516624d4af3b3b97819a9eb
    > Change-Id: Ib5aa00a4d8c82819c08dfc23e2a86f43ebc436c4
    > BUG: 1250582
    > Signed-off-by: Manikandan Selvaganesh <mselvaga at redhat.com>
    > Reviewed-on: http://review.gluster.org/11839
    > Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    > Tested-by: Gluster Build System <jenkins at build.gluster.com>
    > Reviewed-by: Vijaikumar Mallikarjuna <vmallika at redhat.com>
    > Reviewed-by: Atin Mukherjee <amukherj at redhat.com>

    Change-Id: Ib5aa00a4d8c82819c08dfc23e2a86f43ebc436c4
    BUG: 1252297
    Signed-off-by: Manikandan Selvaganesh <mselvaga at redhat.com>
    Reviewed-on: http://review.gluster.org/11879
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list