[Bugs] [Bug 1252680] New: probing and detaching a peer generated a CRITICAL error - "Could not find peer" in glusterd logs

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1252680

            Bug ID: 1252680
           Summary: probing and detaching a peer generated a CRITICAL
                    error - "Could not find peer" in glusterd logs
           Product: GlusterFS
           Version: 3.7.3
         Component: glusterd
          Keywords: Triaged
          Severity: medium
          Assignee: bugs at gluster.org
          Reporter: amukherj at redhat.com
                CC: amukherj at redhat.com, bugs at gluster.org,
                    gluster-bugs at redhat.com, sasundar at redhat.com
        Depends On: 1212437
            Blocks: 1246946



+++ This bug was initially created as a clone of Bug #1212437 +++

Description of problem:
-----------------------
When probing a peer and detaching the same, I observed messages in glusterd log
file with CRITICAL log level

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
glusterfs-3.7 nightly build (glusterfs-3.7dev-0.994.gitf522001.el6.x86_64)

How reproducible:
-----------------
Always

Steps to Reproduce:
-------------------
1. Probe a peer
2. Detach the same peer

Actual results:
---------------
I could see error messages with log-level set to CRITICAL in glusterd logs

Expected results:
-----------------
There shouldn't be any critical errors

--- Additional comment from Anand Avati on 2015-04-16 08:29:58 EDT ---

REVIEW: http://review.gluster.org/10272 (glusterd: log improvement in
glusterd_peer_rpc_notify) posted (#1) for review on master by Atin Mukherjee
(amukherj at redhat.com)

--- Additional comment from Anand Avati on 2015-04-27 02:21:13 EDT ---

REVIEW: http://review.gluster.org/10272 (glusterd: log improvement in
glusterd_peer_rpc_notify) posted (#3) for review on master by Atin Mukherjee
(amukherj at redhat.com)

--- Additional comment from Anand Avati on 2015-04-27 21:03:08 EDT ---

REVIEW: http://review.gluster.org/10272 (glusterd: log improvement in
glusterd_peer_rpc_notify) posted (#4) for review on master by Atin Mukherjee
(amukherj at redhat.com)

--- Additional comment from Anand Avati on 2015-04-29 04:20:06 EDT ---

REVIEW: http://review.gluster.org/10272 (glusterd: log improvement in
glusterd_peer_rpc_notify) posted (#5) for review on master by Atin Mukherjee
(amukherj at redhat.com)

--- Additional comment from Anand Avati on 2015-07-13 01:01:05 EDT ---

REVIEW: http://review.gluster.org/10272 (glusterd: log improvement in
glusterd_peer_rpc_notify) posted (#6) for review on master by Atin Mukherjee
(amukherj at redhat.com)

--- Additional comment from Anand Avati on 2015-08-12 01:05:59 EDT ---

COMMIT: http://review.gluster.org/10272 committed in master by Krishnan
Parthasarathi (kparthas at redhat.com) 
------
commit 0dcdc8d9d797ed43d305fb3e3437c2576305ac46
Author: Atin Mukherjee <amukherj at redhat.com>
Date:   Thu Apr 16 17:54:24 2015 +0530

    glusterd: log improvement in glusterd_peer_rpc_notify

    If ping time out is enabled glusterd can receive a disconnect event from a
peer
    which has been already deleted resulting into a critical log printed. This
patch
    ensures that critical message is logged only when its a connect event.

    Change-Id: I67d9aa3f60195e08af7dfc8a42683422aaf90a00
    BUG: 1212437
    Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-on: http://review.gluster.org/10272
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Gaurav Kumar Garg <ggarg at redhat.com>
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Krishnan Parthasarathi <kparthas at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1212437
[Bug 1212437] probing and detaching a peer generated a CRITICAL error -
"Could not find peer" in glusterd logs
https://bugzilla.redhat.com/show_bug.cgi?id=1246946
[Bug 1246946] critical message seen in glusterd log file, when detaching a
peer, but no functional loss
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.