[Bugs] [Bug 1252348] New: using fop's dict for resolving causes problems

Tue Aug 11 08:41:57 UTC 2015

https://bugzilla.redhat.com/show_bug.cgi?id=1252348

            Bug ID: 1252348
           Summary: using fop's dict for resolving causes problems
           Product: GlusterFS
           Version: 3.7.3
         Component: protocol
          Assignee: bugs at gluster.org
          Reporter: rabhat at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
        Depends On: 1244613, 1244100

+++ This bug was initially created as a clone of Bug #1244613 +++

+++ This bug was initially created as a clone of Bug #1244100 +++

Description of problem:

protocol/server tries to resolve the inodes (of both parent and the entry
dipeneding upon the fop) whenever a fop comes to it, before continuing the fop.
If it cannot find the inode in the inode table for a gfid (soft resolve), then
a lookup is sent on it (hard resolve) to build the inode into the inode table.
For sending the lookup as part of resolve it uses same xdata as that of the
fop. This causes problems in the below situation.

Lru limit has reached. Because of that some of the inodes have been purged. If
all the inodes for the dentries present in a directory are purged, then there
is no one holding the ref on the parent directory's inode. So soon it also gets
moved to the lru list from the active list and might get purged as well if no
one holds a ref on that (means, no new entries are created in it and old
entries present in it are not looked up).

Now if a create operation comes within that directory, protocol/server is not
able to find the inode for the parent directory's gfid and sends a lookup on
it. Now if some xlator wants to get some extended attributes as part of lookup,
then they add their xattr names in the xdata (ex: bit-rot-stub adding version,
sign and bad-object keys into the dict. And the xdata used here is same as that
of the create fop's xdata). The lookup succeeds and now create happens with
extra xattr names added in the xdata and posix as part of create sets those
xattrs. Since bad-object key is also present, this leads to the object that is
created to be treated as bad object for rest of its life and will not allow any
i/o on it.

Version-Release number of selected component (if applicable):

How reproducible:
Easilu if inode-lru-limit is set to 1.

Steps to Reproduce:
1.
2.
3.

Actual results:

Expected results:

Additional info:

http://review.gluster.org/11661 has been sent to master and accepted.

--- Additional comment from Anand Avati on 2015-07-17 02:37:49 EDT ---

REVIEW: http://review.gluster.org/11703 (protocol/server: use different dict
for resolving) posted (#1) for review on release-3.7 by Raghavendra Bhat
(raghavendra at redhat.com)

--- Additional comment from Anand Avati on 2015-07-20 06:44:15 EDT ---

REVIEW: http://review.gluster.org/11718 (tests: set inode-lru-limit to 1 and
check if bit-rot xattrs are wrongy created) posted (#1) for review on master by
Raghavendra Bhat (raghavendra at redhat.com)

--- Additional comment from Anand Avati on 2015-07-21 07:28:58 EDT ---

REVIEW: http://review.gluster.org/11718 (tests: set inode-lru-limit to 1 and
check if bit-rot xattrs are wrongy created) posted (#2) for review on master by
Raghavendra Bhat (raghavendra at redhat.com)

--- Additional comment from Anand Avati on 2015-07-24 09:44:47 EDT ---

REVIEW: http://review.gluster.org/11718 (tests: set inode-lru-limit to 1 and
check if bit-rot xattrs are wrongy created) posted (#3) for review on master by
Raghavendra Bhat (raghavendra at redhat.com)

--- Additional comment from Anand Avati on 2015-07-27 02:44:59 EDT ---

REVIEW: http://review.gluster.org/11718 (tests: set inode-lru-limit to 1 and
check if bit-rot xattrs are wrongy created) posted (#4) for review on master by
Raghavendra Bhat (raghavendra at redhat.com)

--- Additional comment from Anand Avati on 2015-07-29 03:03:31 EDT ---

REVIEW: http://review.gluster.org/11718 (tests: set inode-lru-limit to 1 and
check if bit-rot xattrs are wrongy created) posted (#5) for review on master by
Venky Shankar (vshankar at redhat.com)

--- Additional comment from Anand Avati on 2015-07-31 01:32:42 EDT ---

REVIEW: http://review.gluster.org/11718 (tests: set inode-lru-limit to 1 and
check if bit-rot xattrs are wrongy created) posted (#6) for review on master by
Venky Shankar (vshankar at redhat.com)

--- Additional comment from Anand Avati on 2015-08-03 01:59:56 EDT ---

REVIEW: http://review.gluster.org/11718 (tests: set inode-lru-limit to 1 and
check if bit-rot xattrs are wrongy created) posted (#7) for review on master by
Venky Shankar (vshankar at redhat.com)

--- Additional comment from Anand Avati on 2015-08-04 05:04:32 EDT ---

REVIEW: http://review.gluster.org/11718 (tests: set inode-lru-limit to 1 and
check if bit-rot xattrs are wrongy created) posted (#8) for review on master by
Raghavendra Bhat (raghavendra at redhat.com)

--- Additional comment from Anand Avati on 2015-08-10 07:48:01 EDT ---

REVIEW: http://review.gluster.org/11718 (tests: set inode-lru-limit to 1 and
check if bit-rot xattrs are wrongy created) posted (#9) for review on master by
Raghavendra Bhat (raghavendra at redhat.com)

--- Additional comment from Anand Avati on 2015-08-11 00:22:13 EDT ---

COMMIT: http://review.gluster.org/11718 committed in master by Venky Shankar
(vshankar at redhat.com) 
------
commit c0da330c32312edc4233fe6f660ce8e218638fb5
Author: Raghavendra Bhat <raghavendra at redhat.com>
Date:   Mon Jul 20 16:03:40 2015 +0530

    tests: set inode-lru-limit to 1 and check if bit-rot xattrs are wrongy
created

    This test sets the lru limit of the inode table to 1 and checks if inode
forgets
    and resolve cause any problem with bit-rot xattrs (especially bad-file
xattr).

    Change-Id: I1fa25fa2d31dda8d26e8192562e896e5bddd0381
    BUG: 1244613
    Signed-off-by: Raghavendra Bhat <raghavendra at redhat.com>
    Reviewed-on: http://review.gluster.org/11718
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Venky Shankar <vshankar at redhat.com>

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1244100
[Bug 1244100] using fop's dict for resolving causes problems
https://bugzilla.redhat.com/show_bug.cgi?id=1244613
[Bug 1244613] using fop's dict for resolving causes problems
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.