[Bugs] [Bug 1246794] GF_LOG_NONE logs always

bugzilla at redhat.com bugzilla at redhat.com
Fri Aug 7 19:35:41 UTC 2015


https://bugzilla.redhat.com/show_bug.cgi?id=1246794

Raghavendra Talur <rtalur at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rtalur at redhat.com



--- Comment #5 from Raghavendra Talur <rtalur at redhat.com> ---
The enum, gf_level_strings is used for two things

a. Admin perspective - Messages with what log level and above the admin is
interested in. In this case GF_LOG_NONE means admin wants gluster to never log.

b. Developer perspective - At what level this particular message should be
logged at. In this case, GF_LOG_NONE has *no* meaning. Why would a developer
call gf_msg and say take this message but don't log it.


The original bug was because we did call gf_msg in one place with log_level of
NONE and it was fixed with http://review.gluster.org/#/c/11760.

I would suggest that the only change we do is to only change logic in logging.c
to do a special check for GF_LOG_NONE used by a developer for a message and
skip that log message Or rather log at GF_LOG_DEBUG complaining that gf_msg is
called with GF_LOG_NONE and should never be done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ilQrnkCFd1&a=cc_unsubscribe


More information about the Bugs mailing list