[Bugs] [Bug 1250441] Sharding - Excessive logging of messages of the kind 'Failed to get trusted.glusterfs.shard.file-size for bf292f5b-6dd6-45a8-b03c-aaf5bb973c50'

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1250441



--- Comment #2 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/11843 committed in master by Pranith Kumar
Karampuri (pkarampu at redhat.com) 
------
commit 611b2545b012d1c5d0700af6bc1a182f7aa2343a
Author: Krutika Dhananjay <kdhananj at redhat.com>
Date:   Wed Aug 5 16:58:01 2015 +0530

    features/shard: Fix excessive logging in readdir(p) callback

    On enabling features.shard on a volume which already has few files,
    performing operations on the mount was causing excessive logging of
    messages of the following kind:

    [2015-08-05 10:57:48.743352] E
[shard.c:232:shard_modify_size_and_block_count]
    2-dis-shard: Failed to get trusted.glusterfs.shard.file-size for
    0b2bd401-c438-4d57-8ae5-8d26105d3396

    Turns out this is coming from shard_readdir_cbk() where the shard
    translator unconditionally looks for the xattr
    'trusted.glusterfs.shard.file-size' in every entry's rsp dict and
    logs this error on not finding it. But files that are not sharded
    (i.e., the ones that were created before sharding was enabled on the
volume)
    will not (and should not) have this xattr associated with them.
    So these logs are misleading and must be suppressed in readdir(p).

    Change-Id: I8d268b4f90a8bf744c7851f1984f5a1b6968fb6a
    BUG: 1250441
    Signed-off-by: Krutika Dhananjay <kdhananj at redhat.com>
    Reviewed-on: http://review.gluster.org/11843
    Tested-by: NetBSD Build System <jenkins at build.gluster.org>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are on the CC list for the bug.