[Bugs] [Bug 1149943] duplicate librsync code should likely be linked removed and linked as a library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1149943



--- Comment #10 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/9035 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit 66c789765d783bba8fe651e6a26feb5483af71a5
Author: Niels de Vos <ndevos at redhat.com>
Date:   Sun Nov 2 19:15:49 2014 +0100

    Replace copied (from rsync) checksum code by adler32() from zlib

    The weak checksum code that is included in libglusterfs has initialy
    been copied from the rsync sources. Instead of maintaining a copy of a
    function, we should use a function from a shared library. The algorithm
    seems to be Adler-32, zlib provides an implementation.

    The strong checksum function has already been replaced by MD5 from
    OpenSSL. It is time to also remove the comments about the origin of the
    implementation, because it is not correct anymore.

    Change-Id: I70c16ae1d1c36b458a035e4adb3e51a20afcf652
    BUG: 1149943
    Reported-by: Wade Mealing <wmealing at redhat.com>
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/9035
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=m4GP6TiPMO&a=cc_unsubscribe