[Bugs] [Bug 1166293] New: Libgfapi symbolic version breaking Samba Fedora rawhide (22) koji builds

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1166293

            Bug ID: 1166293
           Summary: Libgfapi symbolic version breaking Samba Fedora
                    rawhide (22)  koji builds
           Product: GlusterFS
           Version: 3.6.0
         Component: libgfapi
          Keywords: Patch
          Severity: urgent
          Priority: urgent
          Assignee: ndevos at redhat.com
          Reporter: ndevos at redhat.com
        QA Contact: sdharane at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
            Blocks: 1163723 (glusterfs-3.6.2), 1166232



+++ This bug was initially created as a clone of Bug #1166232 +++

Description of problem:
The latest changes for libgfapi to keep  version of glusterfs-api.so to "0" is
breaking Samba builds as Samba is looking for "glusterfs-api >= 4" in
gluster-api.pc file. 

Refer http://koji.fedoraproject.org/koji/buildinfo?buildID=593897

Version-Release number of selected component (if applicable):

3.6.1 and later (that includes mainline) 

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

http://koji.fedoraproject.org/koji/buildinfo?buildID=593897

From: https://kojipkgs.fedoraproject.org//work/tasks/7114/8167114/build.log

hecking for glusterfs-api >= 4                                                 
               : not found 
Checking for header api/glfs.h                                                 
                : no 
Checking for library gfapi                                                     
                : yes 
ERROR: Target 'gfapi' in directory /builddir/build/BUILD/samba-4.2.0rc2/source3
re-defined as EMPTY - was SYSLIB
error: Bad exit status from /var/tmp/rpm-tmp.j8Dm9x (%build)
    Macro %python_libdir defined but not used within scope
    Bad exit status from /var/tmp/rpm-tmp.j8Dm9x (%build)
RPM build errors:
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64 --nodeps 
builddir/build/SPECS/samba.spec']
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/mockbuild/trace_decorator.py", line
70, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.7/site-packages/mockbuild/util.py", line 378, in do
    raise mockbuild.exception.Error, ("Command failed. See logs for output.\n #
%s" % (command,), child.returncode)
Error: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64 --nodeps 
builddir/build/SPECS/samba.spec']
LEAVE do --> EXCEPTION RAISED

--- Additional comment from Anand Avati on 2014-11-20 16:42:55 CET ---

REVIEW: http://review.gluster.org/9154 (pkg-config: make the version in
gluster-api.pc backwards compatible) posted (#1) for review on master by Niels
de Vos (ndevos at redhat.com)

--- Additional comment from Niels de Vos on 2014-11-20 17:33:52 CET ---

Build pushed to Fedora Rawhide:
- http://koji.fedoraproject.org/koji/buildinfo?buildID=594572

--- Additional comment from Anand Avati on 2014-11-20 18:57:29 CET ---

COMMIT: http://review.gluster.org/9154 committed in master by Niels de Vos
(ndevos at redhat.com) 
------
commit 6ba258d2b7d4520af95ff638e02598e4aa247ec4
Author: Niels de Vos <ndevos at redhat.com>
Date:   Thu Nov 20 16:26:36 2014 +0100

    pkg-config: make the version in gluster-api.pc backwards compatible

    Once we released gluster-api.pc with version=4. Since then we undid the
    library versioning and replaced it with symbol-versioning. The current
    libgfapi.so has version 0, but the symbols have the version from the
    main package at the time they were added.

    Because other packages (like samba) use the pkg-config version, we can
    not drop it, or decrease the version easily. The simplest solution is to
    keep the version=4 and add sub-digits for the actual package/symbol
    versions. In future, the version in gluster-api.pc will be like 4.3.x.y.

    Change-Id: If359c8de5b847a7e818199a7246636113837da2d
    BUG: 1166232
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/9154
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    Reviewed-by: Lalatendu Mohanty <lmohanty at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1163723
[Bug 1163723] GlusterFS 3.6.2 tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1166232
[Bug 1166232] Libgfapi symbolic version breaking Samba Fedora rawhide (22) 
koji builds
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mdAXbBondt&a=cc_unsubscribe