[Bugs] [Bug 1164503] After readv, md-cache only checks cache times if read was empty

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1164503



--- Comment #2 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/9129 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit 83a4cdaa1972a16603e19916e093674b60680bb0
Author: Niels de Vos <ndevos at redhat.com>
Date:   Sat Nov 15 22:44:09 2014 +0100

    md-cache: cache the iatt when readv() was successful

    When md-cache is handling a readv callback, its logic is to skip
    checking the file's iatt (to see if it has changed since the time of the
    last cache) if "op_ret != 0".

    This is a mistake, and the intent was to skip only on error; for other
    fops, op_ret is 0 on success and nonzero on error, and md-cache has the
    same code for them.

    For readv, though, op_ret is the number of bytes read, so it will
    normally be positive except on EOF.

    BUG: 1164503
    Change-Id: Ifc0f2084b41b6f8d075a9260dc7cf69e97535eed
    Original-author: Philip Spencer <pspencer at fields.utoronto.ca>
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/9129
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Xavier Hernandez <xhernandez at datalab.es>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PuIq3AIqG8&a=cc_unsubscribe