[Bugs] [Bug 1161156] DHT: two problems, first rename fails for a file, second rename failures give different error messages

bugzilla at redhat.com bugzilla at redhat.com
Mon Nov 17 08:25:46 UTC 2014


https://bugzilla.redhat.com/show_bug.cgi?id=1161156



--- Comment #4 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/9063 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit dfc49143841fe84f846346a30dadce797940eebc
Author: Shyam <srangana at redhat.com>
Date:   Thu Nov 6 10:43:37 2014 -0500

    cluster/dht: Fix subvol check, to correctly determine cached file rename

    The check to treat rename as a critical failure ignored when the cached
    file is being renamed to new name, as the new name falls on the same
    subvol as the cached file. This is in addition to when the target of the
    rename does not exist.

    The current change is simpler, as the rename logic, renames the cached
    file in case the target exists and falls on the same subvol as source
    name, OR the target does not exist and the hash of target falls on the
    same subvol as source cached. These conditions mean we are renaming the
    source, other conditions mean we are renaming the source linkto file
    which we do not want to treat as a critical failure (and we also instruct
    marker that it is an internal FOP and to not account for the same).

    Change-Id: I4414e61a0d2b28a429fa747e545ef953e48cfb5b
    BUG: 1161156
    Signed-off-by: Shyam <srangana at redhat.com>
    Reviewed-on: http://review.gluster.org/9063
    Reviewed-by: N Balachandran <nbalacha at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: susant palai <spalai at redhat.com>
    Reviewed-by: venkatesh somyajulu <vsomyaju at redhat.com>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vgdiYdR5Oc&a=cc_unsubscribe


More information about the Bugs mailing list