[Bugs] [Bug 1162226] New: bulk remove xattr should not fail if removexattr fails with ENOATTR/ENODATA

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1162226

            Bug ID: 1162226
           Summary: bulk remove xattr should not fail if removexattr fails
                    with ENOATTR/ENODATA
           Product: GlusterFS
           Version: 3.5.3
         Component: posix
          Assignee: bugs at gluster.org
          Reporter: pkarampu at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com
        Depends On: 1160509



+++ This bug was initially created as a clone of Bug #1160509 +++

Description of problem:
    Bulk remove xattr is internal fop that comes from afr metadata
    self-heal. some xattrs like removexattr("posix.system_acl_access"),
    removes more than one xattr on the file so removexattr on these
    xattrs will fail with either ENODATA/ENOATTR. Since all afr cares
    is removing of these xattrs and if they are already deleted, it can
    treat it as success.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2014-11-04 23:01:48 EST ---

REVIEW: http://review.gluster.org/9049 (storage/posix: Treat ENODATA/ENOATTR as
success in bulk removexattr) posted (#1) for review on master by Pranith Kumar
Karampuri (pkarampu at redhat.com)

--- Additional comment from Anand Avati on 2014-11-05 11:33:29 EST ---

REVIEW: http://review.gluster.org/9049 (storage/posix: Treat ENODATA/ENOATTR as
success in bulk removexattr) posted (#2) for review on master by Pranith Kumar
Karampuri (pkarampu at redhat.com)

--- Additional comment from Anand Avati on 2014-11-06 00:42:56 EST ---

COMMIT: http://review.gluster.org/9049 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit b42255e87a06679b803e6bd83d02465d82c357b6
Author: Pranith Kumar K <pkarampu at redhat.com>
Date:   Wed Nov 5 09:04:50 2014 +0530

    storage/posix: Treat ENODATA/ENOATTR as success in bulk removexattr

    Bulk remove xattr is internal fop in gluster. Some of the xattrs may have
    special behavior. Ex: removexattr("posix.system_acl_access"), removes more
than
    one xattr on the file that could be present in the bulk-removal request.
    Removexattr of these deleted xattrs will fail with either ENODATA/ENOATTR.
    Since all this fop cares is removal of the xattrs in bulk-remove request
and
    if they are already deleted, it can be treated as success.

    Change-Id: Id8f2a39b68ab763ec8b04cb71b47977647f22da4
    BUG: 1160509
    Signed-off-by: Pranith Kumar K <pkarampu at redhat.com>
    Reviewed-on: http://review.gluster.org/9049
    Reviewed-by: Shyamsundar Ranganathan <srangana at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1160509
[Bug 1160509] bulk remove xattr should not fail if removexattr fails with
ENOATTR/ENODATA
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.