[Bugs] [Bug 1160710] libgfapi: use versioned symbols in libgfapi.so for compatibility

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1160710



--- Comment #4 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/9055 committed in release-3.6 by Vijay Bellur
(vbellur at redhat.com) 
------
commit 1ffdf112f707a13c9fd74bbf17f99d28f84f0f0c
Author: Kaleb S. KEITHLEY <kkeithle at redhat.com>
Date:   Wed Nov 5 10:26:46 2014 -0500

    api: versioned symbols in libgfapi.so for compatibility

    Use versioned symbols to keep libgfapi at libgfapi.so.0.0.0

    Some nits uncovered:

    + there are a couple functions declared that do not have an
      associated definition, e.g. glfs_truncate(), glfs_caller_specific_init()

    + there are seven private/internal functions used by heal/src/glfsheal
      and the gfapi master xlator (glfs-master.c): glfs_loc_touchup(),
      glfs_active_subvol(), and glfs_subvol_done(), glfs_init_done(),
      glfs_resolve_at(), glfs_free_from_ctx(), and glfs_new_from_ctx();
      which are not declared in glfs.h;

    + for this initial pass at versioned symbols, we use the earliest version
      of all public symbols, i.e. those for which there are declarations in
      glfs.h or glfs-handles.h.
      Further investigation as we do backports to 3.6, 3.4, and 3.4
      will be required to determine if older implementations need to
      be preserved (forward ported) and their associated alias(es) and
      symbol version(s) defined.

    FWIW, we should consider linking all of our libraries with a map, it'll
    result in a cleaner ABI. Perhaps something for an intern to do or a
    Google Summer of Code project.

    Change-Id: Ie3323e62bb125a3b26214153278b4e998804de0e
    BUG: 1160710
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle at redhat.com>
    Reviewed-on: http://review.gluster.org/9055
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    Tested-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.