[Bugs] [Bug 1176242] glfs_h_creat() leaks file descriptors

bugzilla at redhat.com bugzilla at redhat.com
Sat Dec 20 10:21:01 UTC 2014


https://bugzilla.redhat.com/show_bug.cgi?id=1176242



--- Comment #2 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/9318 committed in master by Niels de Vos
(ndevos at redhat.com) 
------
commit 0e78a12381e988a06e1d5a2dd592d132e24a4e10
Author: Niels de Vos <ndevos at redhat.com>
Date:   Fri Dec 19 18:27:14 2014 +0100

    gfapi: always close the fd in glfs_h_creat()

    When running stress and performance tests against nfs-ganesha, the
    number of open file descriptors increases continously. If the tests run
    long enough, the brick processes will eventually run out of file
    descriptors.

    This seems to be caused by glfs_h_creat() which allocates a 'struct
    glfs_fd', but does not release it. A normal glfs_creat() returns the
    file descriptor to the application, whereas glfs_h_creat() returns a
    handle (struct glfs_object). The file descriptor associated with the
    handle can not be release by glfapi-applications.

    This fd-leak can be prevented by destroying the 'struct glfs_fd' before
    returning the 'struct gfls_object' to the gfapi-application.

    Change-Id: I32465077a35cd0449a8e584c53899b32f022e5af
    BUG: 1176242
    Signed-off-by: Niels de Vos <ndevos at redhat.com>
    Reviewed-on: http://review.gluster.org/9318
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    Reviewed-by: Shyamsundar Ranganathan <srangana at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OQvjU7kiCE&a=cc_unsubscribe


More information about the Bugs mailing list