[Bugs] [Bug 1175753] New: [readdir-ahead]: indicate EOF for readdirp

bugzilla at redhat.com bugzilla at redhat.com
Thu Dec 18 14:02:28 UTC 2014


https://bugzilla.redhat.com/show_bug.cgi?id=1175753

            Bug ID: 1175753
           Summary: [readdir-ahead]: indicate EOF for readdirp
           Product: GlusterFS
           Version: 3.6.1
         Component: unclassified
          Assignee: bugs at gluster.org
          Reporter: vmallika at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com,
                    rabhat at redhat.com
        Depends On: 1174783



+++ This bug was initially created as a clone of Bug #1174783 +++

Description of problem:

posix indicates EOF in readdir call by setting errno to ENOENT. But
readdir-ahead is not doing it and is sending errno as 0. This causes problems
when readdir-ahead is enabled along with USS and is accessed by windows.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2014-12-16 08:32:40 EST ---

REVIEW: http://review.gluster.org/9283 (performance/readdir-ahead: indicate EOF
for readdirp) posted (#1) for review on master by Raghavendra Bhat
(raghavendra at redhat.com)

--- Additional comment from Anand Avati on 2014-12-17 10:05:25 EST ---

REVIEW: http://review.gluster.org/9283 (performance/readdir-ahead: indicate EOF
for readdirp) posted (#2) for review on master by Raghavendra Bhat
(raghavendra at redhat.com)

--- Additional comment from Anand Avati on 2014-12-17 11:20:34 EST ---

REVIEW: http://review.gluster.org/9283 (performance/readdir-ahead: indicate EOF
for readdirp) posted (#3) for review on master by Raghavendra Bhat
(raghavendra at redhat.com)

--- Additional comment from Anand Avati on 2014-12-17 21:50:20 EST ---

COMMIT: http://review.gluster.org/9283 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit cca09a2a342980f427b590f2655d23c371386a02
Author: Raghavendra Bhat <raghavendra at redhat.com>
Date:   Tue Dec 16 19:01:20 2014 +0530

    performance/readdir-ahead: indicate EOF for readdirp

    posix xlator sends op_errno as ENOENT and op_ret as 0, to indicate readdir
has
    been completed. readdir-ahead should send that op_errno that it has saved
in the
    fd context, when it serves the readdir requests. Otherwise some xlators
sitting
    above performance xlators such as snapview-client, which checks for end of
    readdir operation by checking op_ret to 0 and op_errno to ENOENT will not
be
    able to identify end of readdir.

    Change-Id: Ib0835136c61cb1e0d7df933226c479c7db703a71
    BUG: 1174783
    Signed-off-by: Raghavendra Bhat <raghavendra at redhat.com>
    Reviewed-on: http://review.gluster.org/9283
    Reviewed-by: Raghavendra G <rgowdapp at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Brian Foster <bfoster at redhat.com>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1174783
[Bug 1174783] [readdir-ahead]: indicate EOF for readdirp
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list