[Bugs] [Bug 1175732] New: [SNAPSHOT]: nouuid is appended for every snapshoted brick which causes duplication if the original brick has already nouuid

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1175732

            Bug ID: 1175732
           Summary: [SNAPSHOT]: nouuid is appended for every snapshoted
                    brick which causes duplication if the original brick
                    has already nouuid
           Product: GlusterFS
           Version: 3.6.1
         Component: glusterd
          Severity: low
          Assignee: bugs at gluster.org
          Reporter: vmallika at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com,
                    rhinduja at redhat.com, ssamanta at redhat.com,
                    vmallika at redhat.com
        Depends On: 1132026, 1133456



+++ This bug was initially created as a clone of Bug #1133456 +++

+++ This bug was initially created as a clone of Bug #1132026 +++

Description of problem:
=======================

By default we append nouuid xfs option for every snapshot brick during
creation. But if the original volume brick already has nouuid option set and
during snapshot creation another nouuid option is appended than we endup in
having 2 nouuid option for same brick.

For example:
=============

Original volume brick xfs options:

/dev/mapper/RHS_vg2-RHS_lv2 on /rhs/brick2 type xfs
(rw,noatime,allocsize=1MiB,noattr2,barrier,nogrpid,ihashsize=0,noikeep,inode64,largeio,logbufs=4,noalign,nouuid,osyncisosync,quota,gquota,swalloc)

Snapshoted brick xfs options:

/dev/mapper/RHS_vg2-8e87d5ac707343c4b42ea779befc53b2_0 on
/var/run/gluster/snaps/8e87d5ac707343c4b42ea779befc53b2/brick1 type xfs
(rw,noatime,allocsize=1MiB,noattr2,barrier,nogrpid,ihashsize=0,noikeep,inode64,largeio,logbufs=4,noalign,nouuid,osyncisosync,quota,gquota,swalloc,nouuid)


Version-Release number of selected component (if applicable):
=============================================================

glusterfs-3.6.0.27-1.el6rhs.x86_64


How reproducible:
=================
always


Steps to Reproduce:
===================
1. Create a ThinLv brick with nouuid option
2. Create a volume having the above brick
3. Create a snapshot of the volume

Actual results:
===============

Newly created snapshoted brick will have entries of nouuid


Expected results:
==================

If the parent(original) brick already has nouuid, we dont need to add it
explicitly.

--- Additional comment from Anand Avati on 2014-08-25 04:13:57 EDT ---

REVIEW: http://review.gluster.org/8526 (glusterd/snapshot: Don't append nouuid
mount option for snapshot brick if original brick already has this option)
posted (#1) for review on master by Vijaikumar Mallikarjuna
(vmallika at redhat.com)

--- Additional comment from Anand Avati on 2014-11-12 23:23:51 EST ---

REVIEW: http://review.gluster.org/8526 (glusterd/snapshot: Don't append nouuid
mount option for snapshot brick if original brick already has this option)
posted (#2) for review on master by Vijaikumar Mallikarjuna
(vmallika at redhat.com)

--- Additional comment from Anand Avati on 2014-11-13 06:59:13 EST ---

REVIEW: http://review.gluster.org/8526 (glusterd/snapshot: Don't append nouuid
mount option for snapshot brick if original brick already has this option)
posted (#3) for review on master by Vijaikumar Mallikarjuna
(vmallika at redhat.com)

--- Additional comment from Anand Avati on 2014-11-13 23:10:06 EST ---

COMMIT: http://review.gluster.org/8526 committed in master by Krishnan
Parthasarathi (kparthas at redhat.com) 
------
commit f3f7f2a2048359db67875a54a96dbf5a46f7bff3
Author: vmallika <vmallika at redhat.com>
Date:   Thu Nov 13 07:11:00 2014 +0530

    glusterd/snapshot: Don't append nouuid mount option for snapshot brick
    if original brick already has this option

    Change-Id: I2841d2ac371a3e9505f6061f35d1d447946c0bae
    BUG: 1133456
    Signed-off-by: vmallika <vmallika at redhat.com>
    Reviewed-on: http://review.gluster.org/8526
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas at redhat.com>
    Tested-by: Krishnan Parthasarathi <kparthas at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1132026
[Bug 1132026] [SNAPSHOT]: nouuid is appended for every snapshoted brick
which causes duplication if the original brick has already nouuid
https://bugzilla.redhat.com/show_bug.cgi?id=1133456
[Bug 1133456] [SNAPSHOT]: nouuid is appended for every snapshoted brick
which causes duplication if the original brick has already nouuid
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.